NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Didldu-Florian
Didldu-Florian
17 Oct 2020

Fix for #28953 this.modal.open is not a function

Pull Request for Issue #28953

Summary of Changes

initBootsraps Modal

Testing Instructions

Reproduce #28953, test with patch and it did work

Actual result BEFORE applying this Pull Request

Modal did not open, js error:
this.modal.open is not a function

Expected result AFTER applying this Pull Request

Modal should be open and user should be selectable

Documentation Changes Required

nope

avatar Didldu-Florian Didldu-Florian - open - 17 Oct 2020
avatar Didldu-Florian Didldu-Florian - change - 17 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2020
Category JavaScript Repository NPM Change
avatar Razzo1987
Razzo1987 - comment - 17 Oct 2020

This demo is usefully for testing:
subformmodal.zip

avatar Razzo1987 Razzo1987 - test_item - 17 Oct 2020 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 17 Oct 2020

image

I have tested this item successfully on e7f8100


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31129.

avatar ggenovino ggenovino - test_item - 17 Oct 2020 - Tested successfully
avatar ggenovino
ggenovino - comment - 17 Oct 2020

I have tested this item successfully on e7f8100

it's work


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31129.

avatar adj9 adj9 - test_item - 17 Oct 2020 - Tested successfully
avatar adj9
adj9 - comment - 17 Oct 2020

I have tested this item successfully on e7f8100

done:) PBF!!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31129.

avatar alikon
alikon - comment - 17 Oct 2020

@Didldu-Florian can you fix the javascript-cs that was reported by drone please
before to set this as RTC

avatar richard67
richard67 - comment - 17 Oct 2020
495bd5c 17 Oct 2020 avatar Didldu-Florian CS
avatar Didldu-Florian Didldu-Florian - change - 17 Oct 2020
Labels Added: NPM Resource Changed ?
avatar alikon alikon - alter_testresult - 18 Oct 2020 - Razzo1987 : Tested successfully
avatar alikon alikon - alter_testresult - 18 Oct 2020 - ggenovino : Tested successfully
avatar alikon alikon - alter_testresult - 18 Oct 2020 - adj9: Tested successfully
avatar alikon alikon - change - 18 Oct 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 18 Oct 2020

as the last change were only CS the previous tests are still valid

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31129.

avatar richard67 richard67 - change - 19 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-19 21:27:34
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 19 Oct 2020
avatar richard67 richard67 - merge - 19 Oct 2020
avatar richard67
richard67 - comment - 19 Oct 2020

Thanks!

Add a Comment

Login with GitHub to post a comment