[#31124] - [4.0] ArticleModel Client('site') set catid filter to int, because it could be only int
- Closed
- 17 Oct 2020
- Medium
- Build: 4.0-dev
- # 31124
- Diff
- Didldu-Florian:patch-7
User tests: Successful: Unsuccessful:
This solves for following problem #29233. But it finally not solves the real problem!
Currently we have a problem with the "unset" filter in
libraries\src\Form\FormField.php filter() Method,
joomla-cms/libraries/src/Form/FormField.php
Line 1105 in 2ef3952
because it checks any filter input, but "unset" is not really a filter and than it getts into set value null on
joomla-cms/libraries/src/Form/FormField.php
Line 1126 in 2ef3952
Maybe we have some more problems similary to #29233 with filter="unset", So the filter() method in general needs to be improved to work with filter="unset"
Pull Request for Issue #29233
Summary of Changes
Change filter type of catid
Testing Instructions
See Issue #29233 and try to repoduce
Actual result BEFORE applying this Pull Request
Field required: Category.
These is because of filter() Method fails and the catid is set to NULL
Expected result AFTER applying this Pull Request
catid is filtered with "int" and is correct set.
So it works.
Documentation Changes Required
Nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Title |
|
||||||
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-17 10:40:48 |
| Closed_By | ⇒ | Didldu-Florian | |
| Labels |
Added:
?
|
||
This is wrong on its own. Users without certain permissions are not allowed to change the category. That's what
unsetfilter is used for in here. Potentially, though, this could be moved from form validation into model's save method.