? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Oct 2020

PR for #31117

Steps to reproduce the issue

create a module of type mod_article_news readmore
and make sure that you set it to show readmore
publish the module on a page that is NOT com_content

Actual result BEFORE applying this Pull Request

string is displayed as KEY ie ALL CAPS

Expected result AFTER applying this Pull Request

String is displayed as VALUE ie "Read more..."

avatar brianteeman brianteeman - open - 17 Oct 2020
avatar brianteeman brianteeman - change - 17 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2020
Category Language & Strings Layout
avatar Razzo1987
Razzo1987 - comment - 17 Oct 2020

Hi @brianteeman, can you confirm the module is "Articles - Newsflash" ?

avatar gostn gostn - test_item - 17 Oct 2020 - Tested successfully
avatar gostn
gostn - comment - 17 Oct 2020

I have tested this item successfully on 3fa656b

Test on ´Author Login´-page.

without pr

Screenshot_2020-10-17 Author Login

with pr

Screenshot_2020-10-17 Author Login(1)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31123.
avatar Razzo1987
Razzo1987 - comment - 17 Oct 2020

Tested and I think there is something strange:
On a page with com content:
image

On a page without com content (login form):
image

I think the layout must be the same.

Also there is something strange on the languages different from EN on page with com_content:
image

page in FR but label in EN

edit:
The multi language is not a problem. It is because there isn't the string in FR lang file:
image

avatar brianteeman
brianteeman - comment - 17 Oct 2020

The string will always be in english until a translation is created. That is the same for all new strings

avatar br544586 br544586 - test_item - 17 Oct 2020 - Tested successfully
avatar br544586
br544586 - comment - 17 Oct 2020

I have tested this item successfully on 3fa656b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31123.

avatar HLeithner HLeithner - change - 17 Oct 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-17 10:41:51
Closed_By HLeithner
Labels Added: ? ?
avatar HLeithner HLeithner - close - 17 Oct 2020
avatar HLeithner HLeithner - merge - 17 Oct 2020
avatar HLeithner
HLeithner - comment - 17 Oct 2020

Thanks

avatar brianteeman
brianteeman - comment - 17 Oct 2020

Thank you everyone

Add a Comment

Login with GitHub to post a comment