? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
16 Oct 2020

This

  • removes the Javascript tests since they are empty and I doubt that we'll get any tests anytime soon. Don't waste the resources.
  • removes the redis and memcached services. We are testing this properly in the framework project and wont be testing in the CMS for this.
  • removes the cache and reference folder since we don't use them in this pipeline.

The tests should simply still all pass and thats it. Nothing that could really be tested by a normal user/tester.

avatar Hackwar Hackwar - open - 16 Oct 2020
avatar Hackwar Hackwar - change - 16 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2020
Category Unit Tests
avatar Hackwar Hackwar - change - 16 Oct 2020
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 16 Oct 2020

We're not using the framework cache system in the CMS - the jump to the PSR was evaulated as being too much https://github.com/joomla/joomla-cms/tree/4.0-dev/libraries/src/Cache - so we need the cache systems left in place

avatar Hackwar
Hackwar - comment - 17 Oct 2020

Ok, fair enough, but we still don't have any tests for redis or memcached in our test suite right now. The services were just there to prepare for when those tests would be implemented. Since nothing in that regard happened in the last 12 months, we shouldn't waste CPU cycles for this anymore.

avatar Hackwar Hackwar - change - 20 Oct 2020
Labels Added: ?
Removed: ?
avatar Hackwar Hackwar - change - 23 Oct 2020
Labels Added: ?
Removed: ?
avatar HLeithner HLeithner - change - 23 Oct 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-23 20:04:28
Closed_By HLeithner
Labels Added: ?
Removed: ?
avatar HLeithner HLeithner - close - 23 Oct 2020
avatar HLeithner HLeithner - merge - 23 Oct 2020
avatar HLeithner
HLeithner - comment - 23 Oct 2020

thanks

Add a Comment

Login with GitHub to post a comment