? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
16 Oct 2020

Pull Request for Issue #31110

Summary of Changes

Reinstating tips as it is very easy to not understand that the Top Level category does not include that category.
As the lang strings were not deleted it is a simple patch.

Testing Instructions

Create all categories menu items for articles, contact, newsfeeds.

Expected result AFTER applying this Pull Request

Screen Shot 2020-10-16 at 18 39 18

avatar infograf768 infograf768 - open - 16 Oct 2020
avatar infograf768 infograf768 - change - 16 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2020
Category Front End com_contact com_content com_newsfeeds
avatar brianteeman
brianteeman - comment - 16 Oct 2020

This is silly. You have not understood the menu item at all.

This menu item type is called "List all Categories"
So obviously if there are no categories as children of the Top Level category it will not display any categories on the page.

The problem is that you seem to think that it should also list the articles and it doesnt - it lists the categories. Thats why it is called list all categories

avatar infograf768
infograf768 - comment - 16 Oct 2020

You still did not understand the issue as stated in #31110.
There is a bug indeed but the effect is that such a wrong parametered menu item has consequences when the items pertaining to the top level category can’t be displayed and give a 404.

The menu item itself gives a 404...

Even if the bug is solved, it is clever to explain how it works by the existing tip.

avatar brianteeman
brianteeman - comment - 16 Oct 2020

I tested the other issue and the menu does not give a 404

avatar brianteeman
brianteeman - comment - 16 Oct 2020

Reinstating tips as it is very easy to not understand that the Top Level category does not include that category.

You are mistaking the menu item. It is to display categories not articles.

avatar infograf768
infograf768 - comment - 17 Oct 2020

I know what this menu item does.

You are right. No 404, no error, just a blank page when clicking on the allcategories menu item or the link to the category in article top.

The consequences of the error is only visible for the articles concerned when Search Engine Friendly URLs is on.

allcategories

Bug there is, but why have'nt anyone remarked it in the last 10 years? Simple: the tip was there to explain what the menu item would do. Reinstating the tip is simple and does not harm.

Good luck to solve the bug itself...

avatar ceford ceford - test_item - 17 Oct 2020 - Tested successfully
avatar ceford
ceford - comment - 17 Oct 2020

I have tested this item successfully on 17fca47

That better explains what this setting is supposed to do. Good. The original problem remains.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31115.

avatar ceford
ceford - comment - 17 Oct 2020

My Bunkum menu item now uses my Animals top level category. it has one sub-category, Ants. Following the menu link produces this:
image
There is no mention of the parent category, Animals. Pity!

avatar ceford
ceford - comment - 17 Oct 2020

Clearly, I don't know enough about Joomla as a CMS user! It turns out I can set whatever I need above Ant in the Page Display tab. Thank you for your patience.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31115.

avatar infograf768
infograf768 - comment - 17 Oct 2020

To get a mention of your top category level, You have to specify some parameters:
In the case oof root:

Screen Shot 2020-10-17 at 09 26 34

avatar adj9
adj9 - comment - 17 Oct 2020

With root I have
Schermata 2020-10-17 alle 10 52 40

but with a generic category you do not see the articles.

avatar Razzo1987
Razzo1987 - comment - 17 Oct 2020

The XML Description appear under the field, but it doesn't solve the issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31115.

avatar brianteeman
brianteeman - comment - 17 Oct 2020

but with a generic category you do not see the articles.

Because this menu type is to display a list of categories (and if there are articles in those categories they will be displayed).
If you want to have a menu type that displays a list of artciles in the category then you should use the other menu type

avatar Razzo1987
Razzo1987 - comment - 17 Oct 2020

Yes, correct:

Menu:
image

Categories:
image

Frontend:
image

avatar Razzo1987 Razzo1987 - test_item - 17 Oct 2020 - Tested successfully
avatar Razzo1987
Razzo1987 - comment - 17 Oct 2020

I have tested this item successfully on 17fca47

The PR help to doesn't use the item menu category to try to show the article by adding a description.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31115.

avatar Giuse69 Giuse69 - test_item - 17 Oct 2020 - Tested successfully
avatar Giuse69
Giuse69 - comment - 17 Oct 2020

I have tested this item successfully on 17fca47

The description appears and seem to help to understand what will be shown (just categories UNDER selected category)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31115.

avatar alikon alikon - change - 17 Oct 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 17 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31115.

avatar brianteeman
brianteeman - comment - 17 Oct 2020

This PR should not be accepted - it doesnt add anything

avatar richard67 richard67 - change - 17 Oct 2020
Labels Added: ? ?
avatar richard67
richard67 - comment - 17 Oct 2020

... - it doesnt add anything

Hmm, maybe I have fata morgana, but to me it seems to add a description to a text field ?

avatar brianteeman
brianteeman - comment - 17 Oct 2020

it doesnt add anything of value. there was a reason that useless descriptions were removed.

avatar richard67
richard67 - comment - 17 Oct 2020

To me this one seems not to be useless, but that's a matter of taste maybe.

avatar brianteeman
brianteeman - comment - 17 Oct 2020

what does it add? It is obvious. Might as well add them all back :(

avatar HLeithner
HLeithner - comment - 17 Oct 2020

In my opinion the title "List All Categories" and the label "Select a Top Level Category" doesn't fit, isn't there a better wording for it?

Also "ROOT" as the category root is hard to understand for a user, especially when the categories under this "root" node having a wrong indentation.

So instead of adding the description back we should solve the other 3 Text strings and fix the selected list.

avatar ceford
ceford - comment - 17 Oct 2020

I found the tip useful, but that was because I did not understand what would be shown without doing it. So @HLeithner has a point. With another sub-sub-category added I only just realised that 'List All Categories' really means 'List All Categories within a Category'. So I now have Animals / Ants / Flying Ants and with my Ants sub-category selected it comes out like this:
image
I think the combination of 'List All Categories' and the default set to 'Root' was misleading.

avatar brianteeman
brianteeman - comment - 17 Oct 2020

I agree with the problem of the term root - as thats a technical term not familiar to windows users however it is the correct term and it is used throughout joomla

Otherwise I dont see the need for any change.

When you create the menu item you have selected
image

It did exactly what it said it would do but for some reason you thought it would show articles as well

Also please note that this type of menu is not just limited to articles. Any component that has categories has the same menu type eg contacts and newsfeeds. So if this really is a change that must be made then it must be made there as well.

avatar HLeithner
HLeithner - comment - 17 Oct 2020

For me the word "All" is misleading and people don't read descriptions ;-)

Do we have a better word then ROOT?

avatar brianteeman
brianteeman - comment - 17 Oct 2020

For me the word "All" is misleading and people don't read descriptions ;-)

I have no problem with the word ALL being removed

Do we have a better word then ROOT?

Parent? but that still doesn't indicate the very top. And again this term root is used all over joomla

avatar jiweigert
jiweigert - comment - 17 Oct 2020

Top Level /
Main Level /
Main dir(ectory) /
Webroot

All are not perfect, as some user may install Joomla inside of sub-dir(s) of the main root.

What about instead of a static word, but using actually the full resolved path as replacement of "Root"?

Like "<Your domain>(/possible-sub-dir)/"

<Your domain> replaced by the webdomain (if to long, partly shortened)

Don't know if that's better .. or even worse.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31115.

avatar ceford
ceford - comment - 17 Oct 2020

Over on the right the Parent Item is Menu Item Root. I think maybe 'Select a Top Level Category' could be 'Select a Parent Category'. The tip then seems apt.

avatar chmst
chmst - comment - 18 Oct 2020

I agree that the label is bad now. And the PR works as described.
But don't like adding a description here (there are many places where descriptions could be re-added :) )

Suggestion:

"List categories in a category tree"
"Select the parent category"

avatar rdeutz rdeutz - change - 27 Oct 2020
Status Ready to Commit Discussion
avatar rdeutz
rdeutz - comment - 27 Oct 2020

Removing RTC till we agreed on the best solution for the problem


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31115.

avatar gostn
gostn - comment - 28 Nov 2020

Removing RTC till we agreed on the best solution for the problem

one month later …

avatar rdeutz
rdeutz - comment - 15 Mar 2021

Having a description makes sense to me, but even the one in question is not 100% understandable. The menu item shows categories under a category that have (viewable for a user ???) items. Btw. have never used this menu item type, don't see so much value for it.

avatar infograf768
infograf768 - comment - 15 Mar 2021

The all categories menu item (for each component using them) is very handy as it provides correct urls for any display with no specific menu item.
This is why we create it systematically as hidden when installing multilingual sample data.
Screen Shot 2021-03-15 at 14 49 46

avatar brianteeman
brianteeman - comment - 15 Mar 2021

I have no issue with adding a description but it needs to be useful. If it is just stating the obvious it is not useful. If it is just restating what has already been displayed then it not useful. In the specific case that raised this issue the proposed description would have had no impact at all

avatar chmst
chmst - comment - 15 Mar 2021

my suggestion after a speaking with a non technic friend:
No description
better menu item description
Small change in label

categorylist

avatar infograf768
infograf768 - comment - 15 Mar 2021

Good proposal by @chmst
Please make PR. I close this one.

avatar infograf768 infograf768 - change - 15 Mar 2021
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2021-03-15 17:18:36
Closed_By infograf768
Labels Removed: ?
avatar infograf768 infograf768 - close - 15 Mar 2021

Add a Comment

Login with GitHub to post a comment