[#31105] - [4.0] Component configuration deleted on failed validation
- Fixed in Code Base
- 17 Oct 2020
- Medium
- Build: 4.0-dev
- # 31105
- Diff
- SharkyKZ:j4/fix/component-config
User tests: Successful: Unsuccessful:
Fixes #30282.
Summary of Changes
Fixes component configuration being deleted when validation fails.
Testing Instructions
Go to Users component configuration.
Set Minimum Characters to less than 8.
Change some other settings.
Try to save.
Actual result BEFORE applying this Pull Request
Configuration saved message is shown but Minimum Characters is reset to 12, other settings also reset to their default values.
If you go to #__extensions table and inspect params column of com_users record you'll notice it's empty.
Expected result AFTER applying this Pull Request
Form is not saved, Invalid field: Minimum Characters message is shown. Old, valid data in #__extensions table is still there.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31105.
I have tested this item
Showing result as expected
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31105.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31105.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31105.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-17 16:01:28 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Would be nice if you could implement the more meaningful error messages that I tried to implement in #30906