Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31093] - [4.0] Fix Tags Compact list bug

? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
14 Oct 2020

Summary of Changes

Users Notes Categories and Banners Categories can be tagged.
I guess because of the common code for category params.

As they do not have a frontend display layout (normal) they should not have a link to display them in the Tag lists (Compact and normal list).
The code is OK in the normal list

joomla-cms/components/com_tags/tmpl/tag/default_items.php

Lines 81 to 90 in 7044520

<?php if (($item->type_alias === 'com_users.category') || ($item->type_alias === 'com_banners.category')) : ?>
<h3>
<?php echo $this->escape($item->core_title); ?>
</h3>
<?php else : ?>
<h3>
<a href="<?php echo Route::_($item->link); ?>">
<?php echo $this->escape($item->core_title); ?>
</a>
</h3>

But was forgotten in the Compact list menu item layout, therefore getting a link for these Titles and evidently a 404 if clicked.
This PR corrects list_items to solve the bug.

Testing Instructions

Create a tag.
Tag a few items with that tag, including a banners category and a User Notes Category.
Create a Compact List of tagged items menu item.
Display in frontend.

Actual result BEFORE applying this Pull Request

Clickable titles

Screen Shot 2020-10-14 at 18 42 18

Expected result AFTER applying this Pull Request

No more clickable link

Screen Shot 2020-10-14 at 18 40 48

Note:

There are other issues with the queries in /libraries/src/Helper/TagsHelper.php. Will create an issue for this.

avatar infograf768 infograf768 - open - 14 Oct 2020
avatar infograf768 infograf768 - change - 14 Oct 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2020
Category ⇒ com_tags Front End
avatar infograf768 infograf768 - change - 14 Oct 2020
The description was changed
avatar infograf768 infograf768 - edited - 14 Oct 2020
avatar ChristineWk ChristineWk - test_item - 14 Oct 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 14 Oct 2020

I have tested this item ✅ successfully on ab3eadf

I don't usually use tags. That's why I'm always happy to receive your exact test instructions :-)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31093.

avatar ChristineWk
ChristineWk - comment - 14 Oct 2020

screen shot 2020-10-14 at 17 31 35

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31093.

avatar gostn gostn - test_item - 15 Oct 2020 - Tested successfully
avatar gostn
gostn - comment - 15 Oct 2020

I have tested this item ✅ successfully on ab3eadf

thanks for clear test instructions.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31093.

avatar infograf768 infograf768 - change - 15 Oct 2020
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 15 Oct 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31093.

avatar drmenzelit drmenzelit - close - 15 Oct 2020
avatar drmenzelit drmenzelit - merge - 15 Oct 2020
avatar drmenzelit drmenzelit - change - 15 Oct 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-10-15 09:05:31
Closed_By ⇒ drmenzelit
Labels Added: ?
avatar drmenzelit
drmenzelit - comment - 15 Oct 2020

Thanks

Add a Comment

Login with GitHub to post a comment