[#31092] - Added height control and v-scroll to com_admin sidebars
- Fixed in Code Base
- 18 Oct 2020
- Medium
- Build: 4.0-dev
- # 31092
- Diff
- ceford:sidemenuvh
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #30507.
Summary of Changes
Added css to make com_admin index divs limited height vertical scroll
Added code to toggle index display on small screens
Testing Instructions
Go to Admin Home Dashboard / Help / Joomla Help
Scroll to the bottom of the list - a long way - and select the last item
View in responsive mode
Repeat for the Global Configuration page
Apply the patch and then run an npm build
Actual result BEFORE applying this Pull Request
Nothing appears to happen because the iframe to the right is out of sight.
In the small screen view the menu cannot be collapsed.
Expected result AFTER applying this Pull Request
The index div is scrollable and the iframe is always visible - so a selection change is obvious
On small screens the index can be collapsed.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin Templates (admin) NPM Change |
rdeutz
- | Labels |
Added:
NPM Resource Changed
?
|
||
After expanding the menu and clicking on an item should collapse the menu like it is under Global Configuration page.
I think you probably mean the Help index should close in small screens after selecting a new item - looking into it.
Yes, just like the Global configuration page. Toggle the menu, click an item, and menu collapses.
In the Help page I added an id to the index div and a few simple javascript statements to the iframe using onLoad. That is probably not the way it should be done but it is the best I can come up with after looking at the problem all day. Advice accepted!
| Category | Administration com_admin Templates (admin) NPM Change | ⇒ | Administration com_admin com_config Templates (admin) NPM Change |
Removed aria label as suggested. And also in the global configuration page.
The change from 75vh to 100vh was a mistake caused by the intervention of a third party. I have put it back the way it waa - the way I intended.
I have tested this item
Successfully tested, but I still have one question.
Is it intended that you get the list of help pages only by clicking the toggle menu? I would like it to be already open like in the desktop view
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31092.
I have tested this item
if you mean, that the toggle-button should be in the help site, I tested it successfull.
But the menue do not collapse automatically.
tested
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31092.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31092.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-18 09:37:23 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
|
||
Thanks!
The change from 75vh to 100vh was a mistake caused by the intervention of a third party. I have put it back the way it waa - the way I intended.
Why was it a mistake? Should be able to use at least 90vh
Long story! I tried 80 and 75 and opted for the latter. The drone complained that my css statements were in the wrong order. When I tried to fix that I found that someone had changed my PR. That meant that I could not push my clone as usual. Not being experienced in such matters I tried this and I tried that and I tried I dunnowhat. When I did manage force a push I did not notice that vh had been reset to 100vh (by me?). Currently, I think a tad short is better than a tad long.
After expanding the menu and clicking on an item should collapse the menu like it is under Global Configuration page.