NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
11 Oct 2020

Pull Request for Issue #30966.

Summary of Changes

When creating a new filter in Smart Search, clicking the "Expand all" button doesn't have the desired effect. It closes the first tab, while expanding the others and the other way around. This fixes that.

Testing Instructions

Copying the instructions from the original issue:

  1. Joomla 4 -> install blog sample data
  2. Index your content with Smart search
  3. publish all your maps
  4. Create a new Smart Search Filter
  5. Click Expand all button

Actual result BEFORE applying this Pull Request

The first accordion is closed, the rest is opened.

Expected result AFTER applying this Pull Request

All accordions are expanded, the button is renamed to "Collapse all", clicking it again closes all and renames it again to "Expand all".

Documentation Changes Required

None

avatar Hackwar Hackwar - open - 11 Oct 2020
avatar Hackwar Hackwar - change - 11 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2020
Category JavaScript Repository NPM Change
avatar wilsonge wilsonge - change - 15 Oct 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-15 21:48:18
Closed_By wilsonge
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - close - 15 Oct 2020
avatar wilsonge wilsonge - merge - 15 Oct 2020
avatar wilsonge
wilsonge - comment - 15 Oct 2020

Thanks!

Add a Comment

Login with GitHub to post a comment