Joomla! Issue Tracker | Joomla! CMS #31068

? ?

Fixed in Code Base
17 Oct 2020
Medium
Build: 4.0-dev
# 31068
Diff
PhilETaylor:fixstate

Pending

User tests: Successful: Unsuccessful:

PhilETaylor
11 Oct 2020

Summary of Changes

Code review

$state is defined as an integer, and is then not used for the rest of the method as $published is passed to the query,

phpStorm complains that $state is unused

I guess it should be used in the query that follows its casting to int

This PR makes that change

This PR also removes some other "unused" variables.

02b2292 11 Oct 2020

Use correct state int

PhilETaylor - open - 11 Oct 2020

PhilETaylor - change - 11 Oct 2020

Status

New

⇒

Pending

joomla-cms-bot - change - 11 Oct 2020

Category

⇒

Administration com_content

ChristineWk - test_item - 12 Oct 2020 - Tested successfully

ChristineWk - comment - 12 Oct 2020

I have tested this item ✅ successfully on 02b2292

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31068.}

7bf3288 12 Oct 2020

remove unused import

PhilETaylor - change - 12 Oct 2020

Labels

Added: ?

ChristineWk - test_item - 13 Oct 2020 - Tested successfully

ChristineWk - comment - 13 Oct 2020

I have tested this item ✅ successfully on 7bf3288

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31068.}

ceford - test_item - 14 Oct 2020 - Tested successfully

ceford - comment - 14 Oct 2020

I have tested this item ✅ successfully on 7bf3288

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31068.}

alikon - change - 14 Oct 2020

The description was changed

Status

Pending

⇒

Ready to Commit

alikon - comment - 14 Oct 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31068.}

joomla-cms-bot - edited - 14 Oct 2020

richard67 - change - 15 Oct 2020

Status

Ready to Commit

⇒

Pending

richard67 - comment - 15 Oct 2020

Back to pending as changes requested.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31068.}

f525e7f 15 Oct 2020

revert Gets the value of a user state variable and sets it in the session

PhilETaylor - change - 15 Oct 2020

Labels

Added: ?

PhilETaylor - comment - 15 Oct 2020

changes made.

richard67 - comment - 15 Oct 2020

@ChristineWk @ceford Could you repeat your tests? Thanks in advance.

ceford - test_item - 16 Oct 2020 - Tested successfully

ceford - comment - 16 Oct 2020

I have tested this item ✅ successfully on f525e7f

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31068.}

tushar33 - test_item - 17 Oct 2020 - Tested successfully

tushar33 - comment - 17 Oct 2020

I have tested this item ✅ successfully on f525e7f

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31068.}

richard67 - change - 17 Oct 2020

Status

Pending

⇒

Ready to Commit

richard67 - comment - 17 Oct 2020

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31068.}

chmst - change - 17 Oct 2020

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2020-10-17 07:32:20
Closed_By		⇒	chmst
Labels	Added: ? Removed: ?

chmst - close - 17 Oct 2020

chmst - merge - 17 Oct 2020

chmst - comment - 17 Oct 2020

Thanks :)

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#31068] - [4] use integer in sql

Summary of Changes

Add a Comment