Feeling Lucky
No Code Attached Yet
[#31067] - Code logic makes no sense in ColorField
- Closed
- 7 Mar 2022
- Medium
- Build: staging
- # 31067
Steps to reproduce the issue
Code review
English:
if $this->split is not set we do some math... and then immediately overwrite the result of the math but going and checking $this->split again and if its not set, hard coding a 3....
That makes no sense?
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
wilsonge
- comment
- 18 Dec 2020
So I thought about reverting that to the local variable. But given the class property is 3 by default. I have a feeling the 'maths' is just total junk - I can't think of a way $this->split can ever be false
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:39:03 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
No Code Attached Yet
Removed: ? |
||
Removed the J4 tag on this issue as it's an issue since #11030 so affects all of 3.x too