Feeling Lucky
?
?
[#31061] - [4] Return value type is not compatible with declared
- Fixed in Code Base
- 15 Oct 2020
- Medium
- Build: 4.0-dev
- # 31061
- Diff
- PhilETaylor:returntype
User tests: Successful: Unsuccessful:
Summary of Changes
Return value type is not compatible with declared type in PHPDoc block
I chose to remove the return true instead of update the docs (like I have for these #31060) because this method is ONLY called by
where it doesn't need a true to be returned and expects just a void return.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Title |
|
||||||
Quy
- comment
- 12 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31061.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 12 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31061.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-15 16:00:05 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
|
||
richard67
- comment
- 15 Oct 2020
Thanks!
I have tested this item✅ successfully on c35aa5e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31061.