Feeling Lucky
?
?
[#31060] - [4] Update PHPDoc comment to match method signatures in installation app
- Fixed in Code Base
- 15 Oct 2020
- Medium
- Build: 4.0-dev
- # 31060
- Diff
- PhilETaylor:methodsig1
User tests: Successful: Unsuccessful:
Summary of Changes
Update PHPDoc comment to match method signatures in installation app
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 11 Oct 2020
Fixed
ChristineWk
- comment
- 12 Oct 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31060.
ceford
- comment
- 14 Oct 2020
I have tested this item
I really did look at every code change. How sad is that!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31060.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 14 Oct 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31060.
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 15 Oct 2020
applied suggestions blindly.
richard67
- comment
- 15 Oct 2020
Changes after the tests were only code style, indentation, so the previous test results and RTC are still ok. I've added the test result back using the issue tracker.
richard67
- comment
- 15 Oct 2020
I've just finished my pre-merge review. All fine. As soon as drone has passed I'll merge it.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-15 16:59:59 |
| Closed_By | ⇒ | richard67 |
richard67
- comment
- 15 Oct 2020
Thanks!
cs issues