[#3105] - Proposed onAfterRenderModules event in modules rendering
- Closed
- 28 Apr 2016
- Medium
- Build: staging
- # 3105
- Diff
- kanich:patch-1
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
During development and usage of JotCache extension (#13155 on JED) was found that exclusion and dynamic restore of modules during page caching requires processing inside core modules.php code. The best way is to trigger event on the end of template position modules rendering and process all necessary operations in plugin.
Proposed patch is working in JotCache 4.1.0 for J3.2 using class overlay.
nicksavov
- | Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
wilsonge
- | Milestone |
Added: |
||
Kubik-Rubik
- 
Hello @kanich
Thank you for your contribution.
The last comment here was on 27 Mar 2014. So the question is, Is this issue/pull request still valid?
If so please provide clear test instructions to be able to test this pull request.
Please also add a clean line between line 57 and 58 for CS.
If no reply is received within 4 weeks we will close this issue.
Thanks for understanding!
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Milestone |
Removed: |
||
Hello @zero-24
This request for onAfterRenderModules trigger in libraries/joomla/document/html/renderer/modules.php is still valid. I can try to write test for this feature when I get more information about test structure. I found in test/unit/suites/libraries/joomla/document/html/renderer no test relating to modules.php (JDocumentRendererModules class).
This PR has received new commits.
CC: @Kubik-Rubik
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3105.
Are these three issues related #8693 #8296 #3105
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3105.
@brianteeman - #3105 is different PR as the other ones. #3105 is dealing with class JDocumentRendererModules in libraries/joomla/document/html/renderer/modules.php file and not with class JDocumentRendererModule.
@kanich I assume this request is still valid but there are merge conflicts to be solved and we still need clear test instructions so people can test your proposed changes. Can you take a look please?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3105.
@roland-d I wrote unit test for testing proposed change in JDocumentRendererHtmlModules (new class introduced in Joomla 3.5). I do not know where to commit the test file JDocumentRendererHtmlModulesTest.php. It can be appropriate path : unit/suites/libraries/joomla/document/renderer/html/JDocumentRendererHtmlModulesTest.php.
@kanich Looking at the unit test folders I think the best place to put your unit test is tests\unit\suites\libraries\joomla\document\html\renderer\ as this already contains 2 other tests and the test name should be JDocumentRendererModulesTest and so also the filename. You should be good to go then.
Because this PR is over 2 years old it was based on outdated staging repository. Update to current staging repository moved proposed patch from old J3.4 /libraries/joomla/document/html/renderer/modules.php to
/libraries/joomla/document/renderer/html/modules.php and test for this patch is located in /tests/unit/suites/libraries/joomla/document/renderer/html/JDocumentRendererHtmlModulesTest.php (to reflect new directory structure).
Updated patch is in branch 'patch-2' (kanich/joomla-cms)
Closed please see #10113
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3105.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-28 07:24:30 |
| Closed_By | ⇒ | brianteeman |
Thanks for advice. Proposed change tested and implemented in patch.