Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10113] - Proposed onAfterRenderModules event in modules rendering

? ? Success
Pull Request for # 3105

User tests: Successful: Unsuccessful:

avatar kanich
kanich
28 Apr 2016

Pull Request for Issue # .

Summary of Changes

This PR replaces PR #3105 which was based on outdated staging repository (over 2 years old). Update to current staging repository moved proposed patch from old J3.4 /libraries/joomla/document/html/renderer/modules.php to
/libraries/joomla/document/renderer/html/modules.php and test for this patch is located in /tests/unit/suites/libraries/joomla/document/renderer/html/JDocumentRendererHtmlModulesTest.php (to reflect new directory structure).
Updated patch is in branch 'patch-2' (kanich/joomla-cms)

Testing Instructions

Use Joomla unit test for running of /unit/suites/libraries/joomla/document/renderer/html/JDocumentRendererHtmlModulesTest.php. Successfull test run proves correct operation of JDocumentRendererHtmlModules class with proposed change - trigger of onAfterRenderModules event.

…t test

avatar kanich kanich - open - 28 Apr 2016
avatar kanich kanich - change - 28 Apr 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 28 Apr 2016
Category ⇒ Libraries Unit Tests
avatar brianteeman brianteeman - change - 28 Apr 2016
Rel_Number 0 ⇒ 3105
Relation Type ⇒ Pull Request for
Labels
avatar brianteeman brianteeman - change - 28 Apr 2016
Title
…
Updated pull request #3105 to latest stage (2016-04-24) inclusive uni…
Proposed onAfterRenderModules event in modules rendering
avatar brianteeman brianteeman - change - 28 Apr 2016
Labels
avatar brianteeman brianteeman - change - 28 Apr 2016
Title
…
Updated pull request #3105 to latest stage (2016-04-24) inclusive uni…
Proposed onAfterRenderModules event in modules rendering
avatar brianteeman brianteeman - change - 28 Apr 2016
Category Libraries Unit Tests ⇒ Feature Request Libraries Unit Tests
avatar chrisdavenport
chrisdavenport - comment - 2 May 2016

Please fix code style issues. Thanks.

avatar wojsmol
wojsmol - comment - 2 May 2016

@kanich Please see kanich#1

avatar zero-24
zero-24 - comment - 9 May 2016

I have just send you a CS fix for the unit test. Please ping me if you get it in so i can do a quick test.

avatar zero-24 zero-24 - test_item - 9 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 9 May 2016

I have tested this item :white_check_mark: successfully on bb5068a

It works but the final decision is up to the PLT. Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10113.

avatar zero-24 zero-24 - change - 9 May 2016
Status Pending ⇒ Needs Review
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Title
…
Proposed onAfterRenderModules event in modules rendering
Proposed onAfterRenderModules event in modules rendering
avatar brianteeman brianteeman - change - 9 May 2016
Labels Added: ?
avatar roland-d roland-d - test_item - 25 Jun 2016 - Tested successfully
avatar roland-d
roland-d - comment - 25 Jun 2016

I have tested this item ✅ successfully on bb5068a

The test case runs successfully. The code looks good and works as well, I can modify the module buffers.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10113.

avatar roland-d roland-d - change - 25 Jun 2016
Status Needs Review ⇒ Ready to Commit
Labels
avatar roland-d roland-d - change - 25 Jun 2016
Milestone Added:
avatar zero-24
zero-24 - comment - 25 Jun 2016

@roland-d @wilsonge @rdeutz so we can set this RTC or should we wait for a PLT decision?

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2016
Labels Added: ?
avatar roland-d
roland-d - comment - 25 Jun 2016

As far as I am concerned this is RTC for 3.7.

avatar kanich
kanich - comment - 4 Sep 2016

@wilsonge Yes both array parameters have to passed by reference to be able use these parameters in event processing code. See also :
Adds an onAfterRenderModule trigger #8296
abfc4ee

For page caching where cached page often contains several modules is this event used for getting latest module content also in case when the page content is still valid (non expired) in page cache. It is used e.g. for refreshing of ecommerce shopping cart on cached product page.

avatar rdeutz rdeutz - change - 29 Sep 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-09-29 21:02:13
Closed_By ⇒ rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 29 Sep 2016
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Sep 2016
Labels Removed: ? ?

Add a Comment

Login with GitHub to post a comment