[#31045] - Remove old links to images in sample data testing plugin
- Fixed in Code Base
- 16 Mar 2021
- Medium
- Build: 4.0-dev
- # 31045
- Diff
- ghazal:4.0-dev
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
In /plugins/sampledata/testing/language/en-GB/en-GB.plg_sampledata_testing.ini, removal of (obsolete) links to (ugly) images in (obsolete admin template) hathor.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
The sampledata plugin is being rewritten in the joomla/cassiopeia repository so I wouldnt do anything with this for now
@brianteeman As far as I know we handle only blog sample data there, but this issue here is about testing sample data.
@chmst Is my understanding right, or do you plan to handle testing sample data there, too?
It's a simple error, not a super important piece of code. Why leave it as it is while the plugin is being rewritten?
BTW, there are outdated links to beez images as well.
We have 2 plugins:
Blog sample data are rewrittenin cassiopeia.
Testing sample data must be reviewed, in J4, as new features also come with new data. So it does not make much sense to start with a single link. (But this one is really bad :) )
Sorry I didnt see this was for the testing data. There is already an issue open for tracking that. Its never shipped with Joomla and its majorly broken as it is right now.
@brianteeman No problem. And thanks for the hint, I found the issue: #25777 .
Closing this one here as duplicate because it's covered by #25777 .
@ghazal thanks for reporting.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-11 14:17:37 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-10-11 14:17:37 | ⇒ | |
| Closed_By | richard67 | ⇒ |
| Status | New | ⇒ | Pending |
Silly me, it's a PR and not an issue => Re-opening.
Can someone update the title please to show its for the testing plugin
| Title |
|
||||||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31045.
When this is merged we can remove old sample data images too.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31045.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31045.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31045.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31045.
| Status | Pending | ⇒ | Ready to Commit |
RTC again
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31045.
Quy
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-16 22:02:25 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
The sampledata plugin is being rewritten in the joomla/cassiopeia repository so I wouldnt do anything with this for now