?
avatar gostn
gostn
11 Oct 2020

[del]

avatar gostn gostn - open - 11 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 11 Oct 2020
avatar richard67
richard67 - comment - 11 Oct 2020

@brianteeman Does it really needs period at the end of such messages? As far as I (not native English speaker but good knowledge on that language) can see it‘s not a complete sentence because it doesn’t contain a verb, and so it doesn’t need a period. But I might be wrong, and I haven’t checked other texts like this yet. So or so we should be consistent with that.

avatar brianteeman
brianteeman - comment - 11 Oct 2020

@richard67 find is a verb ;)

and although I didnt write anything about the message I did write about tooltips in the style guide stating that they should all have a period (whatever the rules of printed grammar) https://developer.joomla.org/en-gb-user-interface-text-guidelines/punctuation.html

avatar richard67
richard67 - comment - 11 Oct 2020

@richard67 find is a verb ;)

How could I miss that? Maybe It was the subject and not the verb I was missing. I just had the feeling it was not a complete sentence.

Anyway: Who wants to make a pull request?

avatar PhilETaylor
PhilETaylor - comment - 11 Oct 2020

Tab ´Upload Package File´ -> upload a textfile

You should not be able to do that...

Thats a bug too... zero validation on the uploaded file to ensure its a zip/package file :)
#29763 #29865 #29871

avatar richard67
richard67 - comment - 11 Oct 2020

Thats a bug too... zero validation on the uploaded file to ensure its a zip/package file :)
#29763 #29865 #29871

Well, my attempts to fix it were not accepted at the end, as the last 2 of those 3 links show (or other PR's for J3 referred by those).

avatar Quy Quy - change - 26 Oct 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-10-26 22:38:39
Closed_By Quy
avatar Quy
Quy - comment - 26 Oct 2020

Please test PR #31243

avatar Quy Quy - close - 26 Oct 2020
avatar gostn gostn - change - 9 Nov 2020
The description was changed
avatar gostn gostn - edited - 9 Nov 2020
avatar gostn gostn - change - 9 Nov 2020
Title
[4.0] Extensions: Install - add missing period
[del 31044]
avatar gostn gostn - edited - 9 Nov 2020

Add a Comment

Login with GitHub to post a comment