[#31036] - [4][SQL] - batch copy
- Fixed in Code Base
- 27 Oct 2020
- Medium
- Build: 4.0-dev
- # 31036
- Diff
- alikon:patch-117
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
cause of mysql vs postgresql update join different syntax:
- issued different SQL query depending on the db server
- converted SQL to prepared statements
Testing Instructions
batch copy an article (on postgresql)
Actual result BEFORE applying this Pull Request
on postgresql you got an error
Expected result AFTER applying this Pull Request
with both supported db servers you are able to batch copy an article
Additional comment
this issue is present from 3.9.11, and it has been introduced with #24736 by myself
i need more time to prepare a patch for 3 cause of mssql and i don't have a mssql environment to test
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31036.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31036.
There is no way around this sql driver if statement?
not that i'm aware of...
the same happens on com_finder where we are using more complex sql, with a separate driver and even with if like here
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_finder/src/Indexer/Indexer.php#L534
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_finder/src/Indexer/Indexer.php#L558
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_finder/src/Indexer/Indexer.php#L730
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-27 12:48:52 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on dc488b4
* Tested functionality on mysql: 5.6:
passfailedpassThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31036.