?
avatar paternax
paternax
9 Oct 2020

If you set a "CSS Class for tag link" in the tags individual options, the tags loose the classes "badge" and "badge-info". They now have only the new taglink class. I would expect that the tag link class is an additional class to the default classes of the tags.

Steps to reproduce the issue

  • Create a new tag
  • Set a CSS Class for tag link in the Options of the tag
  • Set a Tag in an article
  • Look at the tag in the article

screen shot 2020-10-09 at 18 19 48

Expected result

The tag link class should be an additional class to the default classes of the tags.

Actual result

The Tag with the class has no style, because the classes are gone

screen shot 2020-10-09 at 18 20 36

System information (as much as possible)

Additional comments

avatar paternax paternax - open - 9 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Oct 2020
avatar chmst
chmst - comment - 9 Oct 2020

This is an important question.
If there is a class field for something, image or module or whatever ... is it intended that the class replaces all class entries or should it be appended to existing classes?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31025.
avatar carcam
carcam - comment - 10 Oct 2020

adding the classes just after the existing ones will allow to use current styling and avoid them with your own css if you want. I think classes should be added and not used as a replacement.

Also we need to consider that in other areas of Joomla (menus and modules) the classes were directly added (with no spaces) to the elements. Probably the behaviour should be the same in all other parts.

avatar SharkyKZ
SharkyKZ - comment - 10 Oct 2020

It's fine as it is. If you want to have a common class for all tags, create a layout override and add it there.

avatar brianteeman
brianteeman - comment - 19 Dec 2020

The behaviour should be consistent. You should not need an override to get consistent behaviour

avatar brianteeman
brianteeman - comment - 24 Dec 2020

It is easy to fix but it should be noted first that this behaviour in j4 is the same as in j3

avatar drmenzelit drmenzelit - change - 22 Feb 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-02-22 09:21:11
Closed_By drmenzelit
avatar drmenzelit drmenzelit - close - 22 Feb 2021
avatar drmenzelit
drmenzelit - comment - 22 Feb 2021

Please test #32491

Add a Comment

Login with GitHub to post a comment