? ? Pending

User tests: Successful: Unsuccessful:

avatar artur-stepien
artur-stepien
9 Oct 2020

If you have users activation approved by administrator and administrator is not logged in when he clicks the activation anchor in notification e-mail he will be redirected to the login page. Then after successful authorization he is redirected. The problem is that language filter changes the return url (the activation url) when it doesn't detect Itemid set in the url. With activation URL there is no Itemid set anywhere so it changes the return by wiping ANY redirection data like the most important part - the token. This patch just sets Itemid if it is an internal url and it was not set. That way any redirection data should be safe right now.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar artur-stepien artur-stepien - open - 9 Oct 2020
avatar artur-stepien artur-stepien - change - 9 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Oct 2020
Category Front End Plugins
avatar artur-stepien artur-stepien - change - 9 Oct 2020
Labels Added: ?
avatar zero-24
zero-24 - comment - 10 Oct 2020

@artur-stepien is there a reason this is against 3.10 and not staging / 3.9? To me this sounds like a bug that should be fixed in 3.9 already. Any fix would than be merged up into 3.10 and 4.0. When you agree you can edit the base branch yourself or ping me to do so :-)

avatar artur-stepien
artur-stepien - comment - 11 Oct 2020

@zero-24 Fine for me if you have time. I already spent 3 hours of debugging on this bug.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2020
Category Front End Plugins Unit Tests Repository Administration com_admin
avatar zero-24
zero-24 - comment - 12 Oct 2020

hmm i tried seems it does not work than expected.

avatar artur-stepien
artur-stepien - comment - 12 Oct 2020

Moved to #31076 on staging

avatar artur-stepien artur-stepien - change - 12 Oct 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-10-12 11:58:01
Closed_By artur-stepien
Labels Added: ? ?
avatar artur-stepien artur-stepien - close - 12 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2020
Category Unit Tests Repository Administration com_admin Administration com_admin com_redirect com_templates Repository Front End Plugins
avatar zero-24
zero-24 - comment - 12 Oct 2020

Thanks.

avatar HLeithner HLeithner - change - 6 Jan 2021
Status Closed New
Closed_Date 2020-10-12 11:58:01
Closed_By artur-stepien
Labels Removed: ?
avatar HLeithner HLeithner - change - 6 Jan 2021
Status New Pending
avatar HLeithner HLeithner - reopen - 6 Jan 2021
avatar HLeithner
HLeithner - comment - 6 Jan 2021
avatar HLeithner HLeithner - change - 6 Jan 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-01-06 14:03:42
Closed_By HLeithner
avatar HLeithner HLeithner - close - 6 Jan 2021

Add a Comment

Login with GitHub to post a comment