[#31017] - [4.0] Replace com_content 'Image Float' with 'Image Class
- Fixed in Code Base
- 17 Oct 2020
- Medium
- Build: 4.0-dev
- # 31017
- Diff
- ciar4n:image-class-2
User tests: Successful: Unsuccessful:
This is a rebase of #17402. Opened on request #30924 (comment)
Pull Request for Issue #17399 #30924 .
Summary of Changes
Replaces the 'Image Float ' field in com_contents with an 'Image Class' field
Testing Instructions
Navigate to the Images and Links tab in article edit. Set an image and add a utility class to the Image Class field . Check frontend and ensure class has been applied correctly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Language & Strings Layout Front End Templates (site) NPM Change |
| Labels |
Added:
?
NPM Resource Changed
?
|
||
With the inspection of HTML I see the field
The image of the test is the logo Joomla!
The Image Class field is perhaps more like a list of elements than text.
I have tested this item
Done :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31017.
The previous test is still valid because the commit after that has only changed order of the language string. I've added back the test result in the issue tracker.
Please update the following and remove obsolete strings:
Tested successfully, class is added.
It seems the PR meanwhile has a conflict in file layouts/joomla/content/intro_image.php.
| Labels |
Added:
?
|
||
I've resolved the conflict.
@ChrisHoefliger Could you mark your test result in the issue tracker here? https://issues.joomla.org/tracker/joomla-cms/31017 . Just use the "Test this" button, then select the appropriate test result and then submitt. Please do it in the same way with the other pull requests which you have tested today and where you haven't dome this yet. Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31017.
It still needs to alpha sort the language strings as mentioned by @infograf768 above.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31017.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31017.
| Labels |
Added:
?
Removed: ? |
||
I've allowed myself to fix the language string ordering and I've restored the previous test results.
Can be set to RTC as soon as automated tests have passed.
I have tested this item
testes successfully again :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31017.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31017.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-17 13:18:08 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
?
Removed: ? |
||
Thanks
Looks a good proposal and I see that you have considered the legacy issues. Thanks