? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
9 Oct 2020

Pull Request for Issue #31003.

Summary of Changes

Adds validation rule for redirect header field.

Testing Instructions

Go to Redirects.
In configuration enable Advanced Mode.
Create a new redirect.
Use your browser's developer tools to change the selected value in Redirect Status Code field to something not in the list (e.g. 999).
Save the redirect.
Inspect header column of the redirect in the database (#__redirect_links table).

Actual result BEFORE applying this Pull Request

Redirect saved with 999 as header code.

Expected result AFTER applying this Pull Request

Saving redirect fails with message:

Warning
Invalid field: Redirect Status Code

Documentation Changes Required

avatar SharkyKZ SharkyKZ - open - 9 Oct 2020
avatar SharkyKZ SharkyKZ - change - 9 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Oct 2020
Category Administration com_redirect
avatar SharkyKZ SharkyKZ - change - 9 Oct 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 9 Oct 2020
avatar brianteeman brianteeman - test_item - 9 Oct 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 9 Oct 2020

I have tested this item successfully on d1a8a50


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31016.

avatar viocassel viocassel - test_item - 9 Oct 2020 - Tested successfully
avatar viocassel
viocassel - comment - 9 Oct 2020

I have tested this item successfully on d1a8a50


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31016.

avatar Quy Quy - change - 9 Oct 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31016.

avatar HLeithner HLeithner - change - 9 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-09 11:10:52
Closed_By HLeithner
Labels Added: ? ?
avatar HLeithner HLeithner - close - 9 Oct 2020
avatar HLeithner HLeithner - merge - 9 Oct 2020
avatar HLeithner
HLeithner - comment - 9 Oct 2020

Thanks

Add a Comment

Login with GitHub to post a comment