[#30992] - [4.0] Show a warning if JSON response is corrupted while login
- Closed
- 18 Oct 2020
- Medium
- Build: 4.0-dev
- # 30992
- Diff
- Fedik:admin-login
User tests: Successful: Unsuccessful:
Pull Request for Issue #30898 #27786 and there some others .
Summary of Changes
Show a warning to user if ajax login got incorrect JSON response
Testing Instructions
run npm install and follow one of #30898 #27786
Actual result BEFORE applying this Pull Request
Nothing happen
Expected result AFTER applying this Pull Request
Display a message about what is going on.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
Couldn't language strings be used for the messages so they can be translated?
Server response is corrupted probably should be a language string agreed. I don't mind if the element is missing javascript error is in english only as that's more a developer error.
| Category | Modules Administration JavaScript Repository NPM Change | ⇒ | Administration Language & Strings Modules Templates (admin) JavaScript Repository NPM Change |
okau, I made it translatable,
also I have added "form reset" if user enter wrong name/password
I have tested this item
The message appears with the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30992.
MOD_LOGIN_AJAX_RESPONSE_CORRUPTED="Server response is corrupted, please try to reload the page."
I doubt highly that reloading the page is going to resolve the issue encountered and therefore this message is unhelpful. Suggest something like "Server response was not in the correct format, please try again and contact the site admin if this problem persists"
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-18 10:13:10 |
| Closed_By | ⇒ | Fedik | |
| Labels |
Added:
?
|
||
Please someone, tell me a better message, I will update.