?
avatar atgbcn
atgbcn
13 Feb 2014

error.php line 216
<?php if ((!$statusFixed) && ($this->countModules('status'))) : ?>
needs to be changed by
<?php if ((!$statusFixed) && ($this->getInstance()->countModules('status'))) :?>

$this is instantiated to JDocumentError and it has not countModules method.

avatar atgbcn atgbcn - open - 13 Feb 2014
avatar Bakual
Bakual - comment - 13 Feb 2014

Can you do a PR for that?

avatar atgbcn
atgbcn - comment - 13 Feb 2014

a PR? sorry I'm new to this.

On Thu, Feb 13, 2014 at 8:32 PM, Thomas Hunziker
notifications@github.comwrote:

Can you do a PR for that?

Reply to this email directly or view it on GitHub#3099 (comment)
.

avatar Bakual
Bakual - comment - 13 Feb 2014

PR means a Pull Request. That's the GitHub term for a patch.
It's easier than one might think :smile:

There is a doc page which explains how you can do that: http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

Basically you browse to the file in this repository and end up on this page:
https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/error.php

There you see an Edit button which when pressed allows you to modify the file.
GitHub will automatically make a copy (called Fork) for you in the background.

After you have done the changes, you can save (commit) them and then you can create a Pull Request from there.

avatar atgbcn
atgbcn - comment - 14 Feb 2014

Thanks a lot Thomas! It was really thanks to your help.

Best regards!

Angel

On Thu, Feb 13, 2014 at 9:45 PM, Thomas Hunziker
notifications@github.comwrote:

PR means a Pull Request. That's the GitHub term for a patch.
It's easier than one might think [image: :smile:]

There is a doc page which explains how you can do that:
http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

Basically you browse to the file in this repository and end up on this
page:

https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/error.php

There you see an Edit button which when pressed allows you to modify the
file.
GitHub will automatically make a copy (called Fork) for you in the
background.

After you have done the changes, you can save (commit) them and then you
can create a Pull Request from there.

Reply to this email directly or view it on GitHub#3099 (comment)
.

avatar Bakual
Bakual - comment - 14 Feb 2014

Thanks!
I'm closing this issue now since your PR automatically created a new one (which is normal).
See #3109

avatar Bakual Bakual - change - 14 Feb 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-02-14 11:24:56
avatar Bakual Bakual - close - 14 Feb 2014
avatar zero-24 zero-24 - close - 14 Feb 2014
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?
Removed: ? ?

Add a Comment

Login with GitHub to post a comment