Feeling Lucky
?
[#30953] - [4] Only show error code if greater than zero
- Closed
- 6 Oct 2020
- Medium
- Build: 4.0-dev
- # 30953
- Diff
- PhilETaylor:remove-error-code
User tests: Successful: Unsuccessful:
Summary of Changes
When an error occurs we get an error page, it has a useless error code 0 most of the time.
This PR only shows the error code if its greater than 0
Testing Instructions
Generate an error
URL http://example.com/administrator/index.php?option=com_media&task=file.edit&id=0 will currently do that for you ;-)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
| Category | Administration Templates (admin) | ⇒ | Administration Templates (admin) Installation Front End Templates (site) |
ReLater
- comment
- 6 Oct 2020
Error code 0 is a valid error code in most programming languages. I won't remove it just because it's 0. And more PHP lines in code just for these comparisons.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-06 23:12:44 |
| Closed_By | ⇒ | PhilETaylor |
Looks good but shouldnt it be applied everywhere?