Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30933] - Joomla\CMS\WebAsset\WebAssetManager::addInline() issues

?
avatar SharkyKZ
SharkyKZ
6 Oct 2020

What needs to be fixed

Joomla\CMS\WebAsset\WebAssetManager::addInline() is documented as accepting WebAssetItem (it should probably be WebAssetItemInterface) or string and has broken code for handling WebAssetItem but is typehinted to accept only string.

Also wrong type of exception is thrown (although code is currently unreachable).

avatar SharkyKZ SharkyKZ - open - 6 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 6 Oct 2020
avatar SharkyKZ SharkyKZ - change - 6 Oct 2020
Title
…
Joomla\CMS\WebAsset\WebAssetManager::addInline() wrong typehint
Joomla\CMS\WebAsset\WebAssetManager::addInline() issues
avatar SharkyKZ SharkyKZ - edited - 6 Oct 2020
avatar SharkyKZ SharkyKZ - change - 6 Oct 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 6 Oct 2020
avatar Fedik
Fedik - comment - 6 Oct 2020

makes sense :)
it need to remove typehint, as it for registerAsset()

avatar Fedik
Fedik - comment - 6 Oct 2020

I just noticed, there one more issue, related to it.
I will make a patch when will get some time.

avatar Fedik
Fedik - comment - 7 Oct 2020

please test #30986

avatar Quy Quy - change - 7 Oct 2020
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-10-07 17:46:52
Closed_By ⇒ Quy
avatar Quy Quy - close - 7 Oct 2020

Add a Comment

Login with GitHub to post a comment