[#30932] - [4.0] Restore Joomla\CMS\Helper\ContentHistoryHelper
- Closed
- 25 Jul 2021
- Medium
- Build: 4.0-dev
- # 30932
- Diff
- SharkyKZ:j4/fix/content-history-helper
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Class was removed without deprecation but it still has an alias valid until 5.0. This is causing stub generator to fail.
This restores the class, proxies its code to new Versioning API, and deprecates it for 5.0.
Testing Instructions
Would be good to test that its methods are still working as expected. Besides that try running stub generator script.
Actual result BEFORE applying this Pull Request
Stub generator fails with error:
ReflectionException {#160
#message: "Class Joomla\CMS\Helper\ContentHistoryHelper does not exist"
#code: -1
#file: "build\stubGenerator.php"
#line: 75
trace: {
build\stubGenerator.php:75 {
StubGenerator->doExecute()^
› // Figure out if the alias is for a class or interface
› $reflection = new ReflectionClass($newName);
› $type = $reflection->isInterface() ? 'interface' : 'class';
arguments: {
$argument: "Joomla\CMS\Helper\ContentHistoryHelper"
}
}
libraries\src\Application\CliApplication.php:241 { …}
build\stubGenerator.php:147 { …}
}
}
Expected result AFTER applying this Pull Request
Stub generator works and it's possible to get/delete/store versions using the class.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
This isn't used by core and can only be properly tested by using custom code.
I'm not sure if it's right thing to restore the class, but the fact is that subs generator is broken and restoring this class makes it work again as it's present in classmap file:
joomla-cms/libraries/classmap.php
Line 109 in 12a74a3
If this class is restored, part of this PR should be removing it from list of files marked to delete during migration from 3.10 to 4.0:
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-25 22:41:30 |
| Closed_By | ⇒ | wilsonge |
I could not figure out how to test this. I searched the code for both ContentHistoryHelper and JHelperContenthistory and could not find anything testable. I guess it may be something in Versions - but where?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30932.