No Code Attached Yet
avatar rolandalsace
rolandalsace
5 Oct 2020

Hi.

In com_content ACL in articles (list) view the button state is active in categories where user cannot publish.

I think the problem is on the $user->authorise('core.edit.state', 'com_content.article.' . $item->id) wich don't take the edit state option of the categorie or somethink like this.
But it's strange that in case of article in categorie authorised in modification with edit state to false for the current users group, the button in well desactived ($canChange is false).

To temporarily correct this I overloaded the admin view with change of the line 139 of articles.php

$canChange = $user->authorise('core.edit.state', 'com_content.article.' . $item->id) && $canCheckin;

to

$canChange = $user->authorise('core.edit.state', 'com_content.article.' . $item->id) && $canCheckin && ($canEditOwn || $canEdit);

Regards

avatar rolandalsace rolandalsace - open - 5 Oct 2020
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Oct 2020
avatar rolandalsace rolandalsace - change - 5 Oct 2020
The description was changed
avatar rolandalsace rolandalsace - edited - 5 Oct 2020
avatar rolandalsace rolandalsace - change - 5 Oct 2020
The description was changed
avatar rolandalsace rolandalsace - edited - 5 Oct 2020
avatar rolandalsace rolandalsace - change - 5 Oct 2020
The description was changed
avatar rolandalsace rolandalsace - edited - 5 Oct 2020
avatar rolandalsace rolandalsace - change - 5 Oct 2020
The description was changed
avatar rolandalsace rolandalsace - edited - 5 Oct 2020
avatar joomdonation joomdonation - change - 12 Nov 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-11-12 15:16:22
Closed_By joomdonation
Labels Added: No Code Attached Yet
Removed: ?
avatar joomdonation joomdonation - close - 12 Nov 2022
avatar joomdonation
joomdonation - comment - 12 Nov 2022

I don't check on Joomla 3 but on latest Joomla 4, I could not re-procedure the issue. And by looking at the code, the code for checking edit state permission of article looks perfect fine to me.

With that said, I would say that this issue is invalid (at least for Joomla 4), and close this issue. If you still see the issue with Joomla 4, please give us exactly step by step what we need to do to see the problem you mentioned so that we can check it further if needed.

Add a Comment

Login with GitHub to post a comment