? ? ? Success

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
5 Oct 2020

Summary of Changes

Fixes a fatal error, a warning and deprecation notices on PHP 8.

Warning: Private methods cannot be final as they are never overridden by other classes in libraries\fof\controller\controller.php on line 2156
Deprecated: Required parameter $class follows optional parameter $column in libraries\fof\database\iterator.php on line 89
Deprecated: Required parameter $class follows optional parameter $column in libraries\fof\database\iterator.php on line 108
Fatal error: Declaration of FOFLayoutHelper::render($layoutFile, $displayData = null, $basePath = '') must be compatible with Joomla\CMS\Layout\LayoutHelper::render($layoutFile, $displayData = null, $basePath = '', $options = null) in libraries\fof\layout\helper.php on line 28
Deprecated: Required parameter $itemName follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $tableClass follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $localKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $remoteKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $ourPivotKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $theirPivotKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $pivotTable follows optional parameter $pivot in libraries\fof\table\relations.php on line 901

Testing Instructions

Documentation Changes Required

Developers who extended FOFLayoutHelper should note they need to add an additional argument to its render() method to support PHP 8.

avatar SharkyKZ SharkyKZ - open - 5 Oct 2020
avatar SharkyKZ SharkyKZ - change - 5 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2020
Category External Library Libraries
avatar zero-24
zero-24 - comment - 5 Oct 2020

FOFLayoutHelper should note they need to add an additional argument to its render() method to support PHP 8.

Is that change also required on php 7 or only on / for php 8?

avatar SharkyKZ
SharkyKZ - comment - 5 Oct 2020

PHP 7 only emits a warning.

avatar zero-24
zero-24 - comment - 5 Oct 2020

?

avatar Quy Quy - test_item - 31 Oct 2020 - Tested successfully
avatar Quy
Quy - comment - 31 Oct 2020

I have tested this item successfully on 0a0a4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922.

avatar Quy
Quy - comment - 31 Oct 2020

To reproduce, go to Components > Post-installation Messages.

avatar jwaisner jwaisner - test_item - 2 Nov 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 2 Nov 2020

I have tested this item successfully on 0a0a4e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922.

avatar jwaisner
jwaisner - comment - 2 Nov 2020

@SharkyKZ can you restart drone? Looks like it hasn't reported back on this PR.

I don't expect problems as it tested well but want to ensure all checks pass.

avatar SharkyKZ
SharkyKZ - comment - 3 Nov 2020

@jwaisner I don't see how to.

avatar zero-24
zero-24 - comment - 3 Nov 2020

@jwaisner I don't see how to.

Usually you can trigger drone with a new commit or by updating the branch to the latest staging. Can you try whether that works?

avatar HLeithner
HLeithner - comment - 3 Nov 2020

Seems drone doesn't like the "build message". Please make a new commit

e4b817b 3 Nov 2020 avatar SharkyKZ CS
avatar SharkyKZ
SharkyKZ - comment - 3 Nov 2020

No dice. It doesn't appear on http://ci.joomla.org/joomla/joomla-cms/.

avatar HLeithner HLeithner - change - 3 Nov 2020
The description was changed
avatar HLeithner HLeithner - edited - 3 Nov 2020
avatar HLeithner
HLeithner - comment - 3 Nov 2020

Can you please push again, I removed your emoji from the description...

144536f 3 Nov 2020 avatar SharkyKZ CS
40749a7 3 Nov 2020 avatar SharkyKZ CS
avatar Quy Quy - change - 3 Nov 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Nov 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30922.

avatar HLeithner HLeithner - close - 14 Nov 2020
avatar HLeithner HLeithner - merge - 14 Nov 2020
avatar HLeithner HLeithner - change - 14 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-14 15:04:18
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 14 Nov 2020

Thanks

Add a Comment

Login with GitHub to post a comment