User tests: Successful: Unsuccessful:
Fixes a fatal error, a warning and deprecation notices on PHP 8.
Warning: Private methods cannot be final as they are never overridden by other classes in libraries\fof\controller\controller.php on line 2156
Deprecated: Required parameter $class follows optional parameter $column in libraries\fof\database\iterator.php on line 89
Deprecated: Required parameter $class follows optional parameter $column in libraries\fof\database\iterator.php on line 108
Fatal error: Declaration of FOFLayoutHelper::render($layoutFile, $displayData = null, $basePath = '') must be compatible with Joomla\CMS\Layout\LayoutHelper::render($layoutFile, $displayData = null, $basePath = '', $options = null) in libraries\fof\layout\helper.php on line 28
Deprecated: Required parameter $itemName follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $tableClass follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $localKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $remoteKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $ourPivotKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $theirPivotKey follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Deprecated: Required parameter $pivotTable follows optional parameter $pivot in libraries\fof\table\relations.php on line 901
Developers who extended FOFLayoutHelper
should note they need to add an additional argument to its render()
method to support PHP 8.
Status | New | ⇒ | Pending |
Category | ⇒ | External Library Libraries |
PHP 7 only emits a warning.
I have tested this item
To reproduce, go to Components > Post-installation Messages.
I have tested this item
Seems drone doesn't like the "build message". Please make a new commit
No dice. It doesn't appear on http://ci.joomla.org/joomla/joomla-cms/.
Can you please push again, I removed your emoji from the description...
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-11-14 15:04:18 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
Thanks
Is that change also required on php 7 or only on / for php 8?