Menu item params are mean to include their component's params (from config.xml) on the Edit Menu Item page. This is not happening. There's a TODO in administrator/components/com_menus/models/item.php asking for a fix. I couldn't find a tracker item so here it is.
Left an initial comment in the tracker noting that this causes fields to be duplicated if the fieldset names in default.xml and config.xml are the same. After looking at this further, I'm not sure that the revised code block is necessary or desireable as a way to make component-level config fields overridable at the menuitem level. After all, we already bring those config fields into play by specifically including them in the menuitem manifest (default.xml), often extending the available options with some type of JGLOBAL.
Maybe this block is better off removed entirely? And as part of the cleanup, the two additional $formFile = false on lines 913 and 928 can go as well.
I think you might be right. While the ability to override any and all component params seems like a good idea. It's pretty difficult to work out a consistent, universal way for it to work.
There's an even bigger problem though. A user may have rights to make changes to menu item params but not component params. Should that user be able to override component params on a menu item basis, then? It seems wrong. I suppose this should be removed.
Left an initial comment in the tracker noting that this causes fields to be duplicated if the fieldset names in default.xml and config.xml are the same. After looking at this further, I'm not sure that the revised code block is necessary or desireable as a way to make component-level config fields overridable at the menuitem level. After all, we already bring those config fields into play by specifically including them in the menuitem manifest (default.xml), often extending the available options with some type of JGLOBAL.
Maybe this block is better off removed entirely? And as part of the cleanup, the two additional $formFile = false on lines 913 and 928 can go as well.