? Error
Related to # 3475

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
12 Feb 2014

Menu item params are mean to include their component's params (from config.xml) on the Edit Menu Item page. This is not happening. There's a TODO in administrator/components/com_menus/models/item.php asking for a fix. I couldn't find a tracker item so here it is.

Plus, PHPCS cleanup.

avatar okonomiyaki3000 okonomiyaki3000 - open - 12 Feb 2014
avatar radiant-tech
radiant-tech - comment - 18 Feb 2014

Left an initial comment in the tracker noting that this causes fields to be duplicated if the fieldset names in default.xml and config.xml are the same. After looking at this further, I'm not sure that the revised code block is necessary or desireable as a way to make component-level config fields overridable at the menuitem level. After all, we already bring those config fields into play by specifically including them in the menuitem manifest (default.xml), often extending the available options with some type of JGLOBAL.

Maybe this block is better off removed entirely? And as part of the cleanup, the two additional $formFile = false on lines 913 and 928 can go as well.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 19 Feb 2014

I think you might be right. While the ability to override any and all component params seems like a good idea. It's pretty difficult to work out a consistent, universal way for it to work.

There's an even bigger problem though. A user may have rights to make changes to menu item params but not component params. Should that user be able to override component params on a menu item basis, then? It seems wrong. I suppose this should be removed.

avatar okonomiyaki3000 okonomiyaki3000 - change - 11 Jul 2014
Title
Load component params
[#33264] Load component params
avatar okonomiyaki3000 okonomiyaki3000 - change - 11 Jul 2014
Title
Load component params
[#33264] Load component params
avatar okonomiyaki3000
okonomiyaki3000 - comment - 25 Jul 2014

I can fix this if we really want to do it but I think #3475 is the correct approach.

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar brianteeman brianteeman - change - 16 Oct 2014
Category Administration
avatar brianteeman brianteeman - change - 16 Oct 2014
The description was changed
avatar brianteeman
brianteeman - comment - 17 Oct 2014

as you;ve stated that the approach you took in #3475 is the correct approach for this I am closing this one

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3091.

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Pending Closed
Rel_Number 3475
Relation Type Related to
avatar jissues-bot jissues-bot - close - 17 Oct 2014
avatar jissues-bot
jissues-bot - comment - 17 Oct 2014
avatar jissues-bot jissues-bot - close - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Closed_Date 0000-00-00 00:00:00 2014-10-17 00:26:08
avatar okonomiyaki3000 okonomiyaki3000 - head_ref_deleted - 17 Oct 2014

Add a Comment

Login with GitHub to post a comment