NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
2 Oct 2020

Pull Request for Issue # .

Summary of Changes

Suppress Eslint warning

Testing Instructions

No test needed, the addition is just a comment

Actual result BEFORE applying this Pull Request

Screenshot 2020-10-02 at 19 32 14

Expected result AFTER applying this Pull Request

Screenshot 2020-10-02 at 19 34 42

Documentation Changes Required

No

avatar dgrammatiko dgrammatiko - open - 2 Oct 2020
avatar dgrammatiko dgrammatiko - change - 2 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2020
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 4 Oct 2020
Labels Added: NPM Resource Changed ?
avatar dgrammatiko
dgrammatiko - comment - 17 Oct 2020

@wilsonge this one is a no brainer as well

avatar mqueme
mqueme - comment - 17 Oct 2020

I get other error when running the command
/administrator/components/com_media/resources/scripts/components/browser/items/directory.vue
152:30 error Expected an assignment or function call and instead saw an expression no-unused-expressions
152:95 error Missing semicolon

administrator/components/com_media/resources/scripts/components/modals/modal.vue
21:15 warning Require self-closing on HTML elements () vue/html-self-closing

After applying this PR, the func-names warning is gone.

avatar mqueme mqueme - test_item - 17 Oct 2020 - Tested unsuccessfully
avatar mqueme
mqueme - comment - 17 Oct 2020

I have tested this item ? unsuccessfully on b6cfca1

I get other error when running the command
/administrator/components/com_media/resources/scripts/components/browser/items/directory.vue
152:30 error Expected an assignment or function call and instead saw an expression no-unused-expressions
152:95 error Missing semicolon

administrator/components/com_media/resources/scripts/components/modals/modal.vue
21:15 warning Require self-closing on HTML elements () vue/html-self-closing

After applying this PR, the func-names warning is gone.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30875.

avatar dgrammatiko
dgrammatiko - comment - 17 Oct 2020

@mqueme check the output of drone at the bottom of this pr at GitHub
EB927011-9577-4F1A-93AD-49D0EE108533

avatar dgrammatiko
dgrammatiko - comment - 19 Oct 2020

Closing in favour of #31146

avatar dgrammatiko dgrammatiko - change - 19 Oct 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-10-19 07:33:29
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 19 Oct 2020

Add a Comment

Login with GitHub to post a comment