NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Oct 2020

PR for #30180

No need to load a 200kb image when its only being displayed on a button

Testing Instructions

npm ci and make sure the images in media\plg_system_webauthn\images are 2kb max and not > 200kb

avatar brianteeman brianteeman - open - 1 Oct 2020
avatar brianteeman brianteeman - change - 1 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2020
Category Repository NPM Change
avatar Quy
Quy - comment - 1 Oct 2020

Please make background transparent.

avatar brianteeman
brianteeman - comment - 1 Oct 2020

oops

avatar brianteeman brianteeman - change - 1 Oct 2020
Labels Added: NPM Resource Changed ?
avatar Quy Quy - test_item - 1 Oct 2020 - Tested successfully
avatar Quy
Quy - comment - 1 Oct 2020

I have tested this item successfully on aabc8bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30846.

avatar HLeithner
HLeithner - comment - 1 Oct 2020

Do we have the copyright information for this image?

avatar HLeithner
HLeithner - comment - 2 Oct 2020

I did only a quick search and didn't found it, thanks.

But looking at the repo there is a .ai file wouldn't it be better to use an svg?

avatar brianteeman
brianteeman - comment - 6 Oct 2020

But looking at the repo there is a .ai file wouldn't it be better to use an svg?

I have no opinion on that - its a much bigger code change though

avatar HLeithner
HLeithner - comment - 6 Oct 2020

But looking at the repo there is a .ai file wouldn't it be better to use an svg?

I have no opinion on that - its a much bigger code change though

if would be nice if you can do it.

avatar brianteeman
brianteeman - comment - 6 Oct 2020

I wouldn't know where to start

avatar HLeithner HLeithner - change - 6 Oct 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-06 09:06:02
Closed_By HLeithner
avatar HLeithner HLeithner - close - 6 Oct 2020
avatar HLeithner HLeithner - merge - 6 Oct 2020
avatar HLeithner
HLeithner - comment - 6 Oct 2020

Then we start with this version and if someone want to replace it, it would be good.

thanks

avatar brianteeman
brianteeman - comment - 6 Oct 2020

Thanks

Add a Comment

Login with GitHub to post a comment