? ? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
1 Oct 2020

same as #28409 for 4.0-dev or #28594 for staging but for 4.1-dev

Actual result BEFORE applying this Pull Request

no prebuilt packages for 4.1-dev

Expected result AFTER applying this Pull Request

prebuilt packages for pr's on 4.1-dev

avatar alikon alikon - open - 1 Oct 2020
avatar alikon alikon - change - 1 Oct 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2020
Category Unit Tests
avatar HLeithner
HLeithner - comment - 1 Oct 2020

We will need to sign this change but I will see if it works first, I'm not sure if the compile script can handle this version without modifications

avatar HLeithner
HLeithner - comment - 2 Oct 2020

As I thought we have to update the packager first. Adding the update template for 4.1-dev and update the packing script to support 4.1-dev

avatar sandewt
sandewt - comment - 3 Oct 2020

Finally, does this PR also make it possible to download Joomla 4.1 from the Nightly Builds?

avatar alikon
alikon - comment - 3 Oct 2020

i'm sorry no, this will allow when it will work to have a prebuild dowload package for pr against the 4.1-dev branch, like you currently have for pr against staging and 4.0-dev

avatar zero-24
zero-24 - comment - 3 Oct 2020

Finally, does this PR also make it possible to download Joomla 4.1 from the Nightly Builds?

Thefore we need to setup a jenkins task and update Developer this is not something to be done in the cms repo

avatar sandewt
sandewt - comment - 3 Oct 2020

I assume that for testing these prebuild dowload packages, it is required to test in Joomla! 4.1 anyway.
I think many will drop out if no download is available from Nightly builds.

avatar alikon
alikon - comment - 3 Oct 2020

not exactly the prebuild package will come with all in place to test a pr with 4-1.dev, ie 4.1-dev+pr, like we already have for staging and for 4.0-dev it's an alternative way to test a pr without for example com_patchtester, nightly builds is another thing

avatar zero-24
zero-24 - comment - 3 Oct 2020

PR for the update server has been added here: joomla-projects/docker-images#30 and the branch version has been bumped here: 66573c9

So once that packager PR is deployed and this branch updated this should be OK i guess. cc @HLeithner

avatar alikon alikon - change - 4 Oct 2020
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 4 Oct 2020

@alikon please use this signature: df68dcf150bfb9093f6f8506f631a86ecaf5a62b25e486558abd721cf94c9082

avatar alikon alikon - change - 4 Oct 2020
Labels Added: ? ?
Removed: ?
avatar HLeithner HLeithner - change - 4 Oct 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-04 11:38:34
Closed_By HLeithner
Labels Added: ? ?
Removed: ? ?
avatar HLeithner HLeithner - close - 4 Oct 2020
avatar HLeithner HLeithner - merge - 4 Oct 2020
avatar HLeithner
HLeithner - comment - 4 Oct 2020

thanks

Add a Comment

Login with GitHub to post a comment