[#30839] - [4.0] [NO CACHE] Enable code style for Vue App Media Manager
- Fixed in Code Base
- 17 Oct 2020
- Medium
- Build: 4.0-dev
- # 30839
- Diff
- dgrammatiko:4.0-dev-vue-cs
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Enable Eslint to lint also vue files
- Rename the .js media files to .es6.js so that these could be listed as well
- Fix indentation
- Replace deprecated code
- Fix slots
- Suppress all other errors/warnings
From
✖ 1254 problems (1221 errors, 33 warnings)
1082 errors and 18 warnings potentially fixable with the `--fix` option.
to No errors
Testing Instructions
Check that all the modals and the rest of the media manager functionality is intact
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
?
|
||
Weird because Github shows somes files as deleted/added.
Weird because Github shows somes files as deleted/added.
Are we looking at the same thing? The first commit in this PR clearly shows that I just renamed the files (with git mv as you've asked eg $ git mv translate.js translate.es6.js)
According to SO this is expected: https://stackoverflow.com/questions/2314652/is-it-possible-to-move-rename-files-in-git-and-maintain-their-history
@richard67 could you please restart drone here? Thanks
I'm looking at the Files tab here on Github. Some look to have been moved correctly (e.g getters.js) and others don't. The diff also shows some files being deleted:
diff --git a/administrator/components/com_media/resources/scripts/store/mutations.js b/administrator/components/com_media/resources/scripts/store/mutations.js
deleted file mode 100644
But git blame appears to be intact.
and others don't
Maybe wrong permissions? I honestly redid this PR using git mv. I'm not a git guru...
It depends on your similarity threshold setting in the Git client. In any case git mv oldname newname is just shorthand for:
mv oldname newname
git add newname
git rm oldname
I have tested this item
### Before Patching ###
Modal for previewing an image has an X to close (fa-times icon), allowing you to close the image preview.
After Patching
Modal X no longer visible, had to press escape to close the image preview.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30839.
@richard67 could you restart drone here?
I have tested this item
Tested again after close icon was fixed.
- Image preview modal works
- Create new folder modal works
- Rename file modal works (though renaming a file doesn't trigger a warning that it will affect existing links to the file throughout the site - perhaps needs another issue raised?)
- Delete file modal works
- Delete folder modal works
Everything looks to be working correctly, without any console errors appearing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30839.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-17 00:49:47 |
| Closed_By | ⇒ | wilsonge |
LGTM on review too. Thanks!
Please use
git mvto rename files.