? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Sep 2020

Summary of Changes

The icons used in the tinymce configuration plugin come from a different place than the icons used in the editor itself (I don't know why).

The icons used in the configuration plugin for visualchars and visualblocks were out of date. They are both the identical paragraph icon when the visualblocks icon should have a dotted border as seen in the editor itself

Testing Instructions

apply pr and then node build.js compile-js

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

avatar brianteeman brianteeman - open - 30 Sep 2020
avatar brianteeman brianteeman - change - 30 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Sep 2020
Category JavaScript Repository NPM Change
avatar hans2103 hans2103 - test_item - 1 Oct 2020 - Tested successfully
avatar hans2103
hans2103 - comment - 1 Oct 2020

I have tested this item successfully on 5c11204


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30825.

avatar Quy Quy - test_item - 1 Oct 2020 - Tested successfully
avatar Quy
Quy - comment - 1 Oct 2020

I have tested this item successfully on 5c11204


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30825.

avatar Quy Quy - change - 1 Oct 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 Oct 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30825.

avatar HLeithner HLeithner - change - 1 Oct 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-10-01 17:13:20
Closed_By HLeithner
Labels Added: ? ?
avatar HLeithner HLeithner - close - 1 Oct 2020
avatar HLeithner HLeithner - merge - 1 Oct 2020
avatar HLeithner
HLeithner - comment - 1 Oct 2020

Thanks

avatar brianteeman
brianteeman - comment - 1 Oct 2020

thx

Add a Comment

Login with GitHub to post a comment