[#30822] - Module Class not added in output of mod_custom when Module Style 'inherited' (and using {loadposition})
- Closed
- 3 Feb 2022
- Medium
- Build: master
- # 30822
Steps to reproduce the issue
- Publish a mod_custom module in a position that is generated via the {loadposition position_name} code.
- Set a class in the field 'Module Class' under the 'Advanced' tab of the module.
- Set the Module Style to 'Inherited' (which is the default setting).
Expected result
Output "<div class="mod-custom custom">" has the user set Module Class added,
i.e. "<div class="mod-custom custom my-custom-class">" .
Actual result
The user set Module Class is not added, the output remains "<div class="mod-custom custom">".
System information (as much as possible)
- J!4 beta 4
- Cassiopeia template
Additional comments
Custom class(es) set in the Module Class field will be generated:
- when setting the Module Style to 'default (template: Cassiopeia)';
- when publishing the module in a module position that is defined in templateDetails.xml.
Votes
joomla-cms-bot
- | Labels |
Added:
?
|
||
Thank you Viviana, I would agree with you if the Module Style was set to 'none' . But the Module Style is set to 'inherited'. Here, using the Cassiopeia template, the surrounding div "<div class="mod-custom custom">" is generated but the Module Class is omitted in that div, wether the Module Class is set or not.
Which style has the position (in index.php) where you want to have the module? If the position has style: none, then the module will inherit it.
setting the style to html5 does the trick. however, i agree, when inherited is used, you would expect to see the custom style applied. now this only works with html5 as module style. Even more, the bootstrap size only work when html5 is selected, of not setting bootstrap size has no effect.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30822.
This appears to still be an issue. mod_custom default template doesn't reference the module class at all:
And unless I'm missing something, most of the mod_* items ignore the module class and don't attempt to make moduleclass_sfx available.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30822.
"Inherited" means the module will take the style defined in the template position
<jdoc:include type="modules" name="bg" style="none" />
If the position has style="none" the module will be loaded without chrome around. That is expected behavior.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-03 07:30:50 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
No Code Attached Yet
Removed: ? |
||
Perhaps this is just an adjacent issue, then, but re-read my comment and check the code in mod_custom/tmpl/default.php (and others). No individual module instance style is possible in the template on 4. This was possible in 3 and there was code there to pull the style from the module instance. Adding that code back in an override makes it possible again.
Thank you, mtechoh! Your solution solved the issue: class="mod-custom custom get('moduleclass_sfx') ?>"
J5 with Cassiopeia and the issue is present and pretty annoying.
By default custom module has the inherited style selected. So it takes extra steps for the user to apply custom classes.
Regards
inherited style is correct. the problem is that in many of the position in the template it is set to use style none.
If the module position has no style set it is an expected behaviour. The module chrome "none" doesn't render the div where the module class should be.