[#30821] - [4.0] Technically correct notation for index, follow values
- Closed
- 30 Sep 2020
- Medium
- Build: 4.0-dev
- # 30821
- Diff
- tecpromotion:patch-8
User tests: Successful: Unsuccessful:
Summary of Changes
Technically there is no "No index" or "No follow". See https://developers.google.com/search/reference/robots_meta_tag
In 3.10-dev the lines
joomla-cms/administrator/language/en-GB/en-GB.ini
Lines 432 to 435 in 471ffeb
and
joomla-cms/administrator/language/en-GB/en-GB.ini
Lines 488 to 491 in 471ffeb
are marked with _; Deprecated, will be removed with 4.0. Please do not translate the following language string
_
but strings are still used in 4.0-dev
e.g.
joomla-cms/administrator/components/com_config/forms/application.xml
Lines 642 to 645 in e45709c
My opinion on the topic:
If it is only desired here that it is written apart for the understanding of the user, then this is still misleading, because in the source code the value is then rendered composed. This should also be displayed correctly in the dropdown. Then everyone knows that the displayed string is also the final value.
Testing Instructions
.
Actual result BEFORE applying this Pull Request
JGLOBAL_INDEX_FOLLOW="Index, Follow"
JGLOBAL_INDEX_NOFOLLOW="Index, No follow"
JGLOBAL_NOINDEX_FOLLOW="No index, follow"
JGLOBAL_NOINDEX_NOFOLLOW="No index, no follow"
Expected result AFTER applying this Pull Request
JGLOBAL_INDEX_FOLLOW="index, follow"
JGLOBAL_INDEX_NOFOLLOW="index, nofollow"
JGLOBAL_NOINDEX_FOLLOW="noindex, follow"
JGLOBAL_NOINDEX_NOFOLLOW="noindex, nofollow"
Documentation Changes Required
.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Labels |
Added:
?
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-30 14:13:22 |
| Closed_By | ⇒ | Quy |
Duplicate. See #30399 (comment). Thanks.