[#30806] - Fixed version history modals.
- Fixed in Code Base
- 1 Oct 2020
- Medium
- Build: staging
- # 30806
- Diff
- Harmageddon:fix_version_history_modals
User tests: Successful: Unsuccessful:
Summary of Changes
This PR is an adaptation of the nice JS modal fix #25147 for version 3.x. By calling the script from the button layout instead of every single view using versions, I hope it to be even more elegant (but let me know if this has some flaws I forgot about).
Testing Instructions
- In backend, edit an article.
- Scroll the page down until the toolbar switches to the sticky mode (so it follows the scrolling).
- Click on the "Versions" button.
To test this to full extent, you might want to test this editing the following items:
- Banner
- Banner Client
- Category
- Contact
- Article
- Newsfeed
- Tag
- User Note
Please test in Hathor as well to make sure the PR doesn't break anything there, and modals still work.
Actual result BEFORE applying this Pull Request
The article versions are displayed behind the modal backdrop.
Expected result AFTER applying this Pull Request
The article versions should be displayed on top of the dark background.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript |
Actual result BEFORE applying this Pull Request
The article versions should be displayed on top of the dark background.
Expected result AFTER applying this Pull Request
The article versions are displayed behind the modal backdrop.@Harmageddon Can it be that you've mixed up actual and expected result?
Yes, apparently. :-D Fixed it, thank you! :-)
I have tested this item
Confirm successful test with: Template Isis.
Created Versions for Article/Category/Banner/Contact/Newsfeeds/Tag
Template Hathor: Not possible to check: "Scroll the page down until the toolbar switches to the sticky mode (so it follows the scrolling)" as there was No sticky mode.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30806.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30806.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30806.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30806.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-01 17:07:59 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks even if I think an entire file for one line js code is a bit much ok ;)
@Harmageddon Can it be that you've mixed up actual and expected result?