? Error

User tests: Successful: Unsuccessful:

avatar piotrmocko
piotrmocko
8 Feb 2014

Currently calendar position offset is get from document.body.scrollTop for IE,
but it not always works. Then offset should be get from: document.documentElement.scrollTop if it is defined

Test instructions with module tester on Code Tracker
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=32440

avatar piotrmocko piotrmocko - open - 8 Feb 2014
avatar brianteeman brianteeman - change - 9 Feb 2014
Labels
avatar DOCManLaiThai
DOCManLaiThai - comment - 21 Aug 2014

Test it work for me too!

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar nicksavov nicksavov - change - 21 Aug 2014
Title
Incorrect position of calendar in Internet Explorer 7-10
[#32440] Incorrect position of calendar in Internet Explorer 7-10
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar piotrmocko piotrmocko - change - 21 Aug 2014
Title
Incorrect position of calendar in Internet Explorer 7-10
[#32440] Incorrect position of calendar in Internet Explorer 7-10
avatar brianteeman brianteeman - alter_testresult - 16 Oct 2014 - DOCManLaiThai: Tested successfully
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Title
[#32440] Incorrect position of calendar in Internet Explorer 7-10
Incorrect position of calendar in Internet Explorer 7-10
avatar brianteeman brianteeman - change - 17 Oct 2014
Title
[#32440] Incorrect position of calendar in Internet Explorer 7-10
Incorrect position of calendar in Internet Explorer 7-10
avatar zero-24
zero-24 - comment - 3 Feb 2015

@piotrmocko can you fix the merge conflicts ?

avatar zero-24 zero-24 - change - 3 Feb 2015
Category JavaScript
avatar zero-24 zero-24 - change - 3 Feb 2015
Title
Incorrect position of calendar in Internet Explorer 7-10
Incorrect position of calendar in Internet Explorer 7-10
avatar piotrmocko
piotrmocko - comment - 3 Feb 2015

Yes I can but I do not see here any confilcts. Where do you see those conflicts?

avatar josien
josien - comment - 28 Feb 2015

Could you please add a step-by-step testing procedure, including screen shots with arrows & annotations?
That way the issue + your patch will be easier to test.
Would you be so kind as to respond within 30 days, otherwise this issue will be closed.
Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3079.
avatar josien josien - test_item - 28 Feb 2015 - Not tested
avatar piotrmocko piotrmocko - change - 1 Mar 2015
Title
Incorrect position of calendar in Internet Explorer 7-10
Incorrect position of calendar in Internet Explorer 7-10
avatar piotrmocko piotrmocko - change - 1 Mar 2015
Title
Incorrect position of calendar in Internet Explorer 7-10
[#32440] Incorrect position of calendar in Internet Explorer 7-10
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2015
Title
Incorrect position of calendar in Internet Explorer 7-10
[#32440] Incorrect position of calendar in Internet Explorer 7-10
avatar piotrmocko
piotrmocko - comment - 1 Mar 2015

I have just updated compressed file with current code from staging. But I can see merge conflicts still and I do not know what should I do about it. Could you give me some step by step notes?

avatar roland-d
roland-d - comment - 3 May 2015

@piotrmocko I looked at your PR and I see the following errors:

error: patch failed: media/system/js/calendar.js:1
error: media/system/js/calendar.js: patch does not apply
error: patch failed: media/system/js/calendar.js:1
error: media/system/js/calendar.js: patch does not apply
error: patch failed: media/system/js/calendar.js:1
error: media/system/js/calendar.js: patch does not apply
error: patch failed: media/system/js/calendar.js:1
error: media/system/js/calendar.js: patch does not apply
error: patch failed: media/system/js/calendar.js:1
error: media/system/js/calendar.js: patch does not apply

This means that your calendar.js is not up-to-date with the calendar.js from staging. When I look at a diff from your calendar.js and the staging one, yours seems to be quite a bit smaller while your code change should make it a little longer. You can see the diff here:
piotrmocko@71645ac#diff-94ec1cc82f036da484ebdf6f4af1d05b

So if you take the calendar.js from staging and make the necessary change in that file and then commit it to your branch patch-14, the PR should be OK.

Can you give that a try?

avatar Kubik-Rubik
Kubik-Rubik - comment - 29 Jul 2015

@piotrmocko Thank you for your contribution. Like @roland-d I also still get conflicts but this is not a big problem and I could solve it manually. The problem is how to reproduce your issue. Could you please explain in more detail (step by step) how to see the mentioned problem? Please do it within the next 7 days else I will close this PR. Thank you!

avatar Bakual
Bakual - comment - 29 Jul 2015

Please copy the instructions here. JC is halfway dead already :smile:

avatar piotrmocko
piotrmocko - comment - 29 Jul 2015

How to reproduce the problem and/or test the patch:
See attached images. Install attached module Calendar Tester. Publish in position debug. Open front-end in Internet Explorer 7 - 10. Scroll down to bottom of page where is calendar field. Click on calendar icon. Calendar would open not next to field but at top of document.

http://joomlacode.org/gf/download/trackeritem/32440/85989/calendar1.jpg/open
http://joomlacode.org/gf/download/trackeritem/32440/85988/calendar2.jpg/open
http://joomlacode.org/gf/download/trackeritem/32440/157639/mod_calendartester.zip

avatar Bakual
Bakual - comment - 29 Jul 2015

Adding pictures here.
calendar1
calendar2

avatar Fedik
Fedik - comment - 29 Jul 2015

note: setFullYear() already fixed in #4480

avatar piotrmocko
piotrmocko - comment - 29 Jul 2015

I have reported it 21 months ago, just test my part of fix and if it will be working then maybe there is someone able to correct my pull request to match staging

avatar Kubik-Rubik Kubik-Rubik - change - 6 Aug 2015
Milestone Added:
avatar Kubik-Rubik Kubik-Rubik - reference | 3a1e974 - 6 Aug 15
avatar Kubik-Rubik
Kubik-Rubik - comment - 6 Aug 2015

Please test #7643

avatar Kubik-Rubik Kubik-Rubik - change - 6 Aug 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-08-06 12:30:10
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 6 Aug 2015
avatar Kubik-Rubik Kubik-Rubik - close - 6 Aug 2015
avatar zero-24 zero-24 - change - 6 Aug 2015
Milestone Removed:

Add a Comment

Login with GitHub to post a comment