[#30781] - Change grid minmax definition for newsflash module
- Fixed in Code Base
- 27 Sep 2020
- Medium
- Build: 4.0-dev
- # 30781
- Diff
- drmenzelit:patch-1
User tests: Successful: Unsuccessful:
Change grid minmax definition for newsflash module (horizontal layout) to better fit in small displays
See issue joomla/cassiopeia#119
Summary of Changes
Changed 330px to 200px
Testing Instructions
Run npm ci
Actual result BEFORE applying this Pull Request
The news don't fit on small displays, horizontal scrolling
Expected result AFTER applying this Pull Request
The news fit on small displays, no horizontal scrolling
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
@drmenzelit I'd really like to give this a good test, but I can't reproduce the issue with the 4.0-dev branch here, using Firefox and the screen size simulation from its developer tools. Shall I try on the Cassiopeia repo? Or let's just wait for an other tester with real smarthphone or another tool for somulating that?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30781.
Found out meanwhile.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30781.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30781.
| Labels |
Added:
?
?
NPM Resource Changed
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-27 21:03:34 |
| Closed_By | ⇒ | HLeithner | |
| Labels | |||
Thanks
I have tested this item✅ successfully on 4319f5b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30781.