? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Sep 2020

accessibility

If you have enabled show readmore in the module then it will only display the text "read more" with the link which is ambiguous.

As a result if you are displaying more than one item in the module you have multiple links all with the same ambiguous link name.

additional issues

The text is always "read more" even if you have set a custom text in the article options (globally or per article)

The link title is never displayed even if you have set it to be displayed in the article options (globally or per article)

The read more link in the module has different markup to the readmore link in an article making consistent styling harder

Fix

This PR simply changes the module to use the existing joomla.content.readmore layout

Test

Create a module of type Article News
test the module option for readmore
test all the com_content options for readmore
test all the individual article options for readmore

It is expected that depending on the options above there will be either

  • no readmore
  • readmore + aria label
  • readmore + article title + arial label
avatar brianteeman brianteeman - open - 26 Sep 2020
avatar brianteeman brianteeman - change - 26 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2020
Category Modules Front End
avatar chmst chmst - test_item - 26 Sep 2020 - Tested successfully
avatar chmst
chmst - comment - 26 Sep 2020

I have tested this item successfully on f5999c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30780.

avatar jwaisner jwaisner - test_item - 27 Sep 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 27 Sep 2020

I have tested this item successfully on f5999c5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30780.

avatar jwaisner jwaisner - change - 27 Sep 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 27 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30780.

avatar richard67 richard67 - change - 27 Sep 2020
Labels Added: ? ?
avatar richard67 richard67 - change - 27 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-27 09:14:27
Closed_By richard67
Labels
avatar richard67 richard67 - close - 27 Sep 2020
avatar richard67 richard67 - merge - 27 Sep 2020
avatar richard67
richard67 - comment - 27 Sep 2020

Thanks!

avatar brianteeman
brianteeman - comment - 27 Sep 2020

thx

Add a Comment

Login with GitHub to post a comment