? Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
25 Sep 2020

Pull Request for Issue # .

Summary of Changes

When styling the messages and spacing around it I would like to be able to hide the message box when empty.

#system-message:empty {
    display: none;
}

Because the opening of PHP starts on a new line there is some obsolete spacing rendered.
When PR is merged the empty message box will appear together with its spacing

Testing Instructions

  • Joomla 4 install
  • Inspect element

Actual result BEFORE applying this Pull Request

<div id="system-message">
			</div>

Expected result AFTER applying this Pull Request

<div id="system-message"></div>

Documentation Changes Required

avatar hans2103 hans2103 - open - 25 Sep 2020
avatar hans2103 hans2103 - change - 25 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2020
Category Layout
avatar zero-24
zero-24 - comment - 25 Sep 2020

hmm in layout files we usally have an opening and an closing php tag per line as per our coding rules. Can you give us more context so we might find a better solution for that issue?

avatar hans2103
hans2103 - comment - 25 Sep 2020

.... moment... will adjust my PR... I have an idea

avatar hans2103 hans2103 - change - 25 Sep 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-09-25 06:07:21
Closed_By hans2103
Labels Added: ?
avatar hans2103 hans2103 - close - 25 Sep 2020
avatar hans2103 hans2103 - change - 25 Sep 2020
Status Closed New
Closed_Date 2020-09-25 06:07:21
Closed_By hans2103
avatar hans2103 hans2103 - change - 25 Sep 2020
Status New Pending
avatar hans2103 hans2103 - reopen - 25 Sep 2020
avatar hans2103
hans2103 - comment - 25 Sep 2020

@zero-24 closing in favor of #30760

avatar hans2103 hans2103 - close - 25 Sep 2020
avatar hans2103 hans2103 - change - 25 Sep 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-09-25 06:25:01
Closed_By hans2103

Add a Comment

Login with GitHub to post a comment