Feeling Lucky
?
[#30759] - move opening and closing php of message
- Closed
- 25 Sep 2020
- Medium
- Build: 4.0-dev
- # 30759
- Diff
- hans2103:patch-7
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
When styling the messages and spacing around it I would like to be able to hide the message box when empty.
#system-message:empty {
display: none;
}
Because the opening of PHP starts on a new line there is some obsolete spacing rendered.
When PR is merged the empty message box will appear together with its spacing
Testing Instructions
- Joomla 4 install
- Inspect element
Actual result BEFORE applying this Pull Request
<div id="system-message">
</div>
Expected result AFTER applying this Pull Request
<div id="system-message"></div>
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
hans2103
- comment
- 25 Sep 2020
.... moment... will adjust my PR... I have an idea
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-25 06:07:21 |
| Closed_By | ⇒ | hans2103 | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-09-25 06:07:21 | ⇒ | |
| Closed_By | hans2103 | ⇒ |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-25 06:25:01 |
| Closed_By | ⇒ | hans2103 |
hmm in layout files we usally have an opening and an closing php tag per line as per our coding rules. Can you give us more context so we might find a better solution for that issue?