? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Sep 2020

Pull Request for Issue ##30708 .

Summary of Changes

Change hard coded string in the JS to a translatable constant

Testing Instructions

Apply pr and npm ci
Reduce screen size until we have an ellipsis to dropdown the elements that don't fit anymore in Header.
It still says "More Elements" on hover etc

Note

I am not convinced about the text but unless there are other suggestions its ok

Documentation Changes Required

none

avatar brianteeman brianteeman - open - 21 Sep 2020
avatar brianteeman brianteeman - change - 21 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Sep 2020
Category Administration Language & Strings Templates (admin) JavaScript Repository NPM Change
avatar wilsonge wilsonge - change - 21 Sep 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-21 14:45:21
Closed_By wilsonge
Labels Added: ? NPM Resource Changed ?
avatar wilsonge wilsonge - close - 21 Sep 2020
avatar wilsonge wilsonge - merge - 21 Sep 2020
avatar wilsonge
wilsonge - comment - 21 Sep 2020

Merged on review. Thanks

avatar brianteeman
brianteeman - comment - 21 Sep 2020

thanks

Add a Comment

Login with GitHub to post a comment