[#30717] - [4.0] Fix Debug plugin to display query parameters
- Fixed in Code Base
- 22 Sep 2020
- Medium
- Build: 4.0-dev
- # 30717
- Diff
- Fedik:debug-query-params
User tests: Successful: Unsuccessful:
As additional to #30580
Summary of Changes
This fixing displaying of the SQL query parameters in debugBar.
Also optimised "Call Stack" rendering, that saves ~0.3s for rendering in my tests.
Testing Instructions
Apply path, run npm install
Actual result BEFORE applying this Pull Request
Not possible to view the query parameters
Expected result AFTER applying this Pull Request
Click on "Params" icon to show the table with used query parameters
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
Tested with "MySQLi", "MySQL (PDO)" and "PostgreSQL (PDO)" databases and drivers.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30717.
@Fedik Maybe there is a small improvement possible?
The call stack and the query plan have a bold heading, see green frame in the below screenshot.
Would be nice to have something like that, e.g. "Query Parameters", for the parameters, too.
And there is a little inconsistency, the "Call Stack" heading is only capitalized, but the "QUERY PLAN" is completely uppercase. Maybe the "QUERY PLAN" can be changed to "Query Plan"?
No need to do it with this PR here, future PR is also ok for me.
"Call Stack" heading is only capitalized, but the "QUERY PLAN" is completely uppercase.
"Explain table" rendered based on SQL response.
"QUERY PLAN" comes from SQL response for PostgreSQL, similar for MySQL headings all table columns comes from SQL response.
And "Call Stack" is hard-coded in the debugbar.
| Labels |
Added:
?
|
||
Added, and update a styling a bit, to make it a little better readable
I have tested this item
@Fedik You are my hero ;-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30717.
using the Prebuilt package i've got strange results
i'll re-test later on a proper npm environment
yea, that exact result with old JS
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30717.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30717.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-22 17:36:07 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? |
||
Thanks!
Adding release blocker label as the original issue #30318 had it, and PR #30580 had only fixed one aspect while this PR now fixes the remaining issue.