NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
19 Sep 2020

Pull Request for Issue #30683 .

Summary of Changes

Add and remove CSS class "collapse" also for the sidebar wrapper when resizing the screen, in the same way as it is already done for the sidebar nav.

Testing Instructions

It needs current 4.0-dev for testing because last nightly build or Beta 4 don't include PR #30131 yet.

  1. In backend on a desktop screen, reduce browser window width until the admin menu on the left hand side disappears and the burger button is shown at the bottom right corner.
  2. Click on the burger button.
    Result: The admin menu which is now at the bottom of the screen is expanded => ok.
  3. Click again on the burger button.
    Result: The admin menu at the bottom of the screen is collapsed => ok.
  4. Enlarge browser window width until the burger button disappears.
    Result: See section "Actual result BEFORE applying this Pull Request" below.
  5. Apply the patch of this PR.
  6. Run npm run build:js or npm ci.
  7. Clear browser cache or at least forced reload the backend page to get rid of cached old js.
  8. Reppeat steps 1 to 4.
    Result: See section "Expected result AFTER applying this Pull Request" below.

The issue happened to me also sometimes when skipping steps 2 and 3, but only when the particular page was shown for the very first time in that session, and even then not in all cases, so it was hard to reproduce. With steps 2 and 3 I could reproduce it reliably.

Actual result BEFORE applying this Pull Request

The admin menu remains invisible.

After a page reload the admin menu appears with collapsed status on the left hand side.

Expected result AFTER applying this Pull Request

The admin menu appears again at the left hand side.

Documentation Changes Required

None.

Additional information

I have no idea if this fix is the right fix. But it works. Hoping for feedback of experts.

avatar richard67 richard67 - open - 19 Sep 2020
avatar richard67 richard67 - change - 19 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2020
Category JavaScript Repository NPM Change
avatar richard67 richard67 - change - 19 Sep 2020
Title
[4.0] [Atum] Admin menu remaining hidden when enlarging screen width from small mobile to larger
[4.0] [Atum] Fix admin menu remaining hidden when enlarging screen width from small mobile to larger
avatar richard67 richard67 - edited - 19 Sep 2020
avatar richard67 richard67 - change - 19 Sep 2020
The description was changed
avatar richard67 richard67 - edited - 19 Sep 2020
avatar infograf768 infograf768 - test_item - 19 Sep 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 19 Sep 2020

I have tested this item successfully on 44d1794


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30686.

avatar alikon alikon - test_item - 20 Sep 2020 - Tested successfully
avatar alikon
alikon - comment - 20 Sep 2020

I have tested this item successfully on 44d1794


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30686.

avatar alikon alikon - change - 20 Sep 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 20 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30686.

avatar infograf768 infograf768 - change - 21 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-21 09:58:14
Closed_By infograf768
Labels Added: NPM Resource Changed ? ?
avatar infograf768 infograf768 - close - 21 Sep 2020
avatar infograf768 infograf768 - merge - 21 Sep 2020
avatar infograf768
infograf768 - comment - 21 Sep 2020

Tks

Add a Comment

Login with GitHub to post a comment