Joomla! Issue Tracker | Joomla! CMS #30593 - [4.0] adding additional check to avoid js script error

NPM Resource Changed ?

Fixed in Code Base
11 Sep 2020
Medium
Build: 4.0-dev
# 30593
Diff
pdkpavankumar:image-rotation-js-error

Pending

User tests: Successful: Unsuccessful:

pdkpavankumar
8 Sep 2020

Pull Request for Issue # . #29157

Summary of Changes

added additional check in js file to avoid script error

Testing Instructions

Go to edit an image in the Media Manager
Click the Rotate tab
Click the buttons 0, 90, 180, 270 to rotate the image

Actual result BEFORE applying this Pull Request

TypeError: c.querySelector(...) is null -- rotate.min.js:1:1416

Expected result AFTER applying this Pull Request

No script error should come and functionality should work as is.

Documentation Changes Required

0e63726 8 Sep 2020

adding additional check to avoid js script error

pdkpavankumar - open - 8 Sep 2020

pdkpavankumar - change - 8 Sep 2020

Status

New

⇒

Pending

joomla-cms-bot - change - 8 Sep 2020

Category

⇒

JavaScript Repository NPM Change

6e8dd5c 8 Sep 2020

fixing js lint error

pdkpavankumar - change - 8 Sep 2020

Labels

Added: NPM Resource Changed ?

Quy - test_item - 8 Sep 2020 - Tested successfully

Quy - comment - 8 Sep 2020

I have tested this item ✅ successfully on 6e8dd5c

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30593.}

pdkpavankumar - change - 10 Sep 2020

Title

…

adding additional check to avoid js script error

[4.0] adding additional check to avoid js script error

pdkpavankumar - edited - 10 Sep 2020

wilsonge - change - 11 Sep 2020

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2020-09-11 11:18:53
Closed_By		⇒	wilsonge

wilsonge - close - 11 Sep 2020

wilsonge - merge - 11 Sep 2020

wilsonge - comment - 11 Sep 2020

Thanks!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#30593] - [4.0] adding additional check to avoid js script error