?
avatar leoalv
leoalv
3 Sep 2020

The repeatable custom field is the most loved and used in Joomla 3.X, in the alpha versions of Joomla 4 it seemed that they were going to keep it, but in the beta version it is no longer there and it was replaced by subfield.
Do you plan to reintegrate the repeatble custom field? Is there a way to migrate these fields to the new subfield?

Currently doing a migration this gives an error.

Steps to reproduce the issue

  • Create a repeatable custom field in joomla 3.9.21
  • Create a article using this custom field in Joomla 3.9.21
  • Upgrade to Joomla 3.10. alpha
  • Upgrade to Joomla 4.0.beta3

Expected result

The repeating field should work.

Actual result

It is not possible to create articles, and it shows errors in the section of custom fields

System information (as much as possible)

Warning: Declaration of PlgFieldsRepeatable::onCustomFieldsPrepareDom($field, DOMElement $parent, JForm $form) should be compatible with Joomla\Component\Fields\Administrator\Plugin\FieldsPlugin::onCustomFieldsPrepareDom($field, DOMElement $parent, Joomla\CMS\Form\Form $form)

Additional comments

When the repeatable field was checked in Joomla 3.10 alpha, it was working fine. The problem is in Joomla 4.0 beta3. so it is necessary to know what will happen with this. Thank you

avatar leoalv leoalv - open - 3 Sep 2020
avatar joomla-cms-bot joomla-cms-bot - change - 3 Sep 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Sep 2020
avatar zero-24
zero-24 - comment - 3 Sep 2020

hmm on upgrade that field should be uninstalled and convert to the subform field: #28319

So it seems that migration did not happen for some reason to be investigated.

avatar micker
micker - comment - 4 Sep 2020

Hello i didnt find any Doc about migration to subfield some link ?

avatar zero-24
zero-24 - comment - 4 Sep 2020

Well the intention is that this migration is done on upgrade as mention in the PR linked above. I did not had time to check what goes wrong on upgrade that this does not happen.

avatar zero-24 zero-24 - change - 5 Sep 2020
Labels Added: ?
avatar zero-24 zero-24 - labeled - 5 Sep 2020
avatar zero-24 zero-24 - change - 5 Sep 2020
Title
[4] Repeatable Custom field
[4.0] Repeatable Custom field
avatar zero-24 zero-24 - edited - 5 Sep 2020
avatar zero-24
zero-24 - comment - 5 Sep 2020

I have just confirmed that this migration script seems not work correctly after the upgrade the field is still repeatable and not converted to ``subform` it seems only one new editor field is created on upgrade. @Hackwar can you take a look here?

image

avatar Llewellynvdm
Llewellynvdm - comment - 28 Oct 2020

@Hackwar @wilsonge to me it looks like a migration fail higher in the execution, that affects/prevents the repeatable fields update to complete. I will run a few more passes on this to check until where we have the execution stack of the migration working as expected. Here is the path I have been going about five times now already...

Running a test going from v3.9.22 -> v4.0.0-beta5-Beta

image
image
image

Start Migration to Joomla_3.10.0-alpha3-Alpha

image
image
image
image
image

Start Migration to Joomla_4.0.0-beta5-Beta

image
image
image
image
image
image
image

Repeatable Field was not updated

image

Trying to open the article with the Repeatable Field Fails, and I can also not create a new article

image
image
image
image

avatar wilsonge
wilsonge - comment - 8 Feb 2021

Fixed the fatal on upgrade. Now the field migrates to a subform field - and other articles can correctly create data. However the existing 3.x data doesn't get upgraded - which requires fixing still (hence this remains open)

avatar Llewellynvdm
Llewellynvdm - comment - 8 Feb 2021

Thanks for this update, was waiting for this fix on the upgrade path, will now take a closer look at this.

avatar joomdonation
joomdonation - comment - 8 Mar 2021

I created PR #32611 to migrate data. Hopefully we can close this Release Blocker issue :).

avatar chmst chmst - change - 8 Mar 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-03-08 11:01:53
Closed_By chmst
avatar chmst chmst - close - 8 Mar 2021
avatar chmst
chmst - comment - 8 Mar 2021

Closing as we have a PR.

avatar wilsonge wilsonge - change - 12 Mar 2021
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 12 Mar 2021

Add a Comment

Login with GitHub to post a comment