[#30555] - [4.0] Redundant words
- Fixed in Code Base
- 3 Sep 2020
- Medium
- Build: 4.0-dev
- # 30555
- Diff
- brianteeman:simply
User tests: Successful: Unsuccessful:
This is a repeat of #18852
Remove just from strings … it is a redundant word and is subjective.
“Just” makes me feel like an idiot. “Just” presumes I come from a specific background, studied certain courses in university, am fluent in certain technologies, and have read all the right books, articles, and resources. “Just” is a dangerous word. http://bradfrost.com/blog/post/just/
Also removes easily and simply as they are also redundant and subjective
There is also a use of "just this category" which I have changed to "only this category" for clarity
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
| Labels |
Added:
?
?
|
||
Any reason for changing plg_sampledata_testing as it will not be shipped with packages?
Well it is shipped with dev packages so why should we not change it there too? Some language might translate it too.
Some language might translate it too.
Where would they ship that? The file is (correctly) not proposed in crowdin and will not be as it will not be part of releases.
Where would they ship that? The file is (correctly) not proposed in crowdin and will not be as it will not be part of releases.
Well I said might not that they do and the plan is that it will still be possible to do non crowdin packages ;) So why should we not fix that for the core even when translations might or might not translate it?
As you like. I was just pointing the facts.
| Category | Administration Language & Strings Front End Plugins | ⇒ | Administration Language & Strings |
I have no energy for pointless arguments. This is now just for com_privacy strings
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30555.
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30555.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30555.
Merging for now
@brianteeman I have just discussed with @infograf768 and we agreed to change the strings you mention too. Do you want to do a dedicated PR yourself or should I take that strings over?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-03 08:21:01 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
When taking over the strings or making a new PR, please correct string "PLG_SAMPLEDATA_TESTING_SAMPLEDATA_CONTENT_ARTICLE_37_INTROTEXT". It contains a leftover "and" which should be removed, too: "It shows how you can quickly and build a personal site" should be changed to "It shows how you can quickly build a personal site".
Ok will do than a PR based on your commit and the comment by Richard myself.
Any reason for changing plg_sampledata_testing as it will not be shipped with packages?