? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Sep 2020

Pull Request for Issue #30551
This simple PR flips the display of the plugin from the right hand side to the left hand side in LTR languages and the opposite in RTL languages

This is to avoid clashing with the menu icon on mobile displays.

On desktops it probably makes more sense this way as its with the menus.

Steps to reproduce the issue

Enable Plugin: System - Additional Accessibility Features
mobile view
scroll to bottom

BEFORE LTR

image

AFTER LTR

image

AFTER RTL

image

avatar brianteeman brianteeman - open - 2 Sep 2020
avatar brianteeman brianteeman - change - 2 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2020
Category Front End Plugins
avatar Quy Quy - test_item - 2 Sep 2020 - Tested successfully
avatar Quy
Quy - comment - 2 Sep 2020

I have tested this item successfully on 2b1ce7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30552.

avatar paternax paternax - test_item - 2 Sep 2020 - Tested successfully
avatar paternax
paternax - comment - 2 Sep 2020

I have tested this item successfully on 2b1ce7b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30552.

avatar Quy Quy - change - 2 Sep 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 2 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30552.

avatar brianteeman
brianteeman - comment - 2 Sep 2020

Drone errors are completely unrelated and just the usual test that fails

avatar laoneo laoneo - change - 3 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-03 11:34:49
Closed_By laoneo
Labels Added: ? ?
avatar laoneo laoneo - close - 3 Sep 2020
avatar laoneo laoneo - merge - 3 Sep 2020
avatar laoneo
laoneo - comment - 3 Sep 2020

Thanks!

avatar brianteeman
brianteeman - comment - 3 Sep 2020

thanks

Add a Comment

Login with GitHub to post a comment